Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ports Radial menu for Janitorial cart from TG #8426

Merged
merged 3 commits into from
May 8, 2020
Merged

ports Radial menu for Janitorial cart from TG #8426

merged 3 commits into from
May 8, 2020

Conversation

Jumps0
Copy link
Contributor

@Jumps0 Jumps0 commented May 7, 2020

Intent of your Pull Request

The janitorial cart now uses a radial menu instead of an HTML UI menu. Credit to Arkatos1 for the original code.
dreamseeker_2rnWZLWlN1

Changelog

馃啈 Arkatos
rscadd: Janitorial cart now uses a radial menu
/:cl:

@yogstation13-bot yogstation13-bot added the Feature This adds new content to the game label May 7, 2020
@Jumps0
Copy link
Contributor Author

Jumps0 commented May 7, 2020

booo

@Jumps0
Copy link
Contributor Author

Jumps0 commented May 7, 2020

heck yea

@Xoxeyos
Copy link
Contributor

Xoxeyos commented May 7, 2020

We shouldn't add too many radial menus to things, it's just going to junk things up, in my opinion.

@Jumps0
Copy link
Contributor Author

Jumps0 commented May 7, 2020

We shouldn't add too many radial menus to things, it's just going to junk things up, in my opinion.

could you clarify what you mean by "junk things up"?

@Marmio64
Copy link
Contributor

Marmio64 commented May 7, 2020

radial menus is good though

@Hopekz
Copy link
Contributor

Hopekz commented May 7, 2020

I like the radial menu's
They bring us to the modern age instead of weird list menus. Especially for things like this with about 7 selections.

@swissloaf swissloaf added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 8, 2020
@Hopekz Hopekz merged commit 51d19fb into yogstation13:master May 8, 2020
yogstation13-bot added a commit that referenced this pull request May 8, 2020
@yogstation13-bot
Automatic changelog generation #8426 [ci skip]
93ee1c1
@Jumps0 Jumps0 deleted the janiradial branch May 11, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Feature This adds new content to the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jumps0 @Xoxeyos @Marmio64 @Hopekz @yogstation13-bot @swissloaf