Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial menus for mining equipment voucher redeeming #8433

Merged
merged 3 commits into from
May 10, 2020

Conversation

Jumps0
Copy link
Contributor

@Jumps0 Jumps0 commented May 9, 2020

Intent of your Pull Request

Replaces the list menu for redeeming mining vouchers with a radial menu. This effects both the regular mining equipment vendor and the free miner mining equipment vendor (The free golem vendor appears to be the exact same as the normal one).

Regular Mining Vendor:
D4QtkmMp0Q

Free Miner Mining Vendor:
a9tsgTfBns

Changelog

馃啈
rscadd: Radial menus for redeeming mining vouchers
/:cl:

@yogstation13-bot yogstation13-bot added the Feature This adds new content to the game label May 9, 2020
@Jumps0
Copy link
Contributor Author

Jumps0 commented May 9, 2020

i actually coded something, nice

@Hopekz Hopekz self-assigned this May 9, 2020
@Hopekz Hopekz added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 9, 2020
@TheGamerdk
Copy link
Contributor

You can't stop me Hopek

@TheGamerdk
Copy link
Contributor

If you're up for the task maybe you could refactor the machines, so that the items list is defined on the machine. Then you don't have to mirror the whole proc for the free miner one, and it would be easier to make new voucher rewards

@TheGamerdk
Copy link
Contributor

Or maybe not, just took a look and it might not be the easiest

@Jumps0
Copy link
Contributor Author

Jumps0 commented May 9, 2020

I didn't understand half the things you just said but I'm glad you feel i'm capable of something. @TheGamerdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Feature This adds new content to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants