Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves the ai into sat and comms into the center. (Boxstation big changes) #8531

Merged
merged 33 commits into from Jun 6, 2020

Conversation

smorgli
Copy link
Contributor

@smorgli smorgli commented May 16, 2020

Intent of your Pull Request

This is a big one.
I moved the ai into it's sat and tcomms into the center of boxstation.

Other changes include :
Moving the upload outside of the ai core like it should be.
Moving the board storage closer to engi.
Moving the gravgen into a shielded secure area in engi.

Screenshots:

Tcomms(updated):
dreamseeker_Nj8gygf33Q
dreamseeker_inHuYEyFTl
dreamseeker_FgbxMsg5dU
Overview:
dreamseeker_sW82dFYrKG

AI Core:
dreamseeker_RN6IsbAPog
dreamseeker_y2kMHMSlcU
dreamseeker_vmQRte42WG
dreamseeker_UJkPbEFxbC
dreamseeker_LlEiwnj6d1
dreamseeker_hqua7xRpSy
dreamseeker_wp6ZaUJ1RJ
Overview:
dreamseeker_Nyuj2ZkNoi
dreamseeker_FMyu62VYwx

What the AI sees:
aicore

AI upload:
dreamseeker_OVJqrTn7W8

Board storage:
dreamseeker_qG4pnc5BVD

Gravgen:
dreamseeker_R73aXQvJe5

Changelog

🆑
tweak: ai is now in sat, comms are now in center, upload is in board storage, board storage is in gravgen, gravgen is in smes.
/:cl:

@smorgli smorgli requested a review from Ktlwjec1 as a code owner May 16, 2020 12:01
@yogstation13-bot yogstation13-bot added Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels May 16, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented May 16, 2020

See discord for my comments

@alexkar598
Copy link
Member

Ai needs external cams if it's on a sat

@smorgli
Copy link
Contributor Author

smorgli commented May 16, 2020

Ai needs external cams if it's on a sat

See gif in description

@smorgli
Copy link
Contributor Author

smorgli commented May 16, 2020

Tcomms updated as per suggestion

@MegaEmpirical
Copy link

I'll admit this is nicely done. I'm willing to try this.

Also, anyone using a vendrobe is a monster and you shoud feel bad.

@swissloaf swissloaf added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 16, 2020
@Readystorm546
Copy link
Contributor

Okay so what makes box special is that there is an AI core at the center of the station. As for this im okay with it IF its random between the tow. Like a 50/50 chance for both layouts

@MegaEmpirical
Copy link

Ohh flipping between the map style would be cool. I think generally that's been really great with the engine and the bar.

Also, there are some symmetry issues I'll tell you about when I get home later.

@Jarod1200
Copy link

Does 7 turrets in the ai core feel like a bit much?

@smorgli
Copy link
Contributor Author

smorgli commented May 16, 2020

Okay so what makes box special is that there is an AI core at the center of the station. As for this im okay with it IF its random between the tow. Like a 50/50 chance for both layouts

That was a plan initially but i decided not to do this since i didn't know what to put in the former upload

Does 7 turrets in the ai core feel like a bit much?

The core is mostly a copypaste from metastation. I feel as if this is justified since it's more exposed in space

@johnnyboyz25
Copy link

About AI placement:

  • Not sure if it's intentional design, but the windows exterior to the upload computers would be about as easy to breach&access from space as the upload board within secure storage.
  • If the AI is malf/subverted, this setup would make the AI a pain in the ass to kill.
  • If it's a nukeops round, this setup would expose the AI far more (equipment availability).
  • If a tator is tasked with stealing the AI, this setup would be a pain in the ass for an already difficult objective. BloodBrothers more so.
  • I'm not 100% confident of what the computers are at the base of the former tcomms admin room, but they look like a power monitor + alerts console. Perhaps it would be more useful to see a AI integrity resolving console there? Another borgs console?
  • Could put a borg recharger on the AI satellite?

As for Tcomms/Gravgen:

  • Seldom is knocking out Tcomms worth the risk / work for a typical antag. Thus, I like the windows added between the tcomms servers and the public hallway. Perhaps lighten security even more? I'm not sure if the centcomm-style doors have extra health or wire shielding by default, but seeing tcomms knocked out more often could lead to more interesting gameplay. Perhaps a tcomms-painted engineering door could be added.
  • Gravgen, similarly, is seldom worth the work or risk to mess with. What is the point of moving it, apart from making more space for the upload?

Interesting PR, I think this could see a few changes:

  • Agree w ReadyStorm, variable/unpredictable layouts would be neat.
  • Agree w Jarod, it feels like there's a few too many turrets
  • Face the AI core towards the door to its core, so it is easier to rush into?
  • More windows to Tcomms? Window from bridge as well? Make it easier to break into in general?
  • Integrity+borg computers in former tcomms admin room.
  • Give RD enough access to get to AI core? AI is more RnD's job to maintain/upgrade than engineering's.

Thoughts?

@smorgli
Copy link
Contributor Author

smorgli commented May 17, 2020

In no particular order:

I like the AI core the way it is, if ktl does not request it I won't change much in there.
Variable layouts are for a different PR that i can't promise I will actually make.
RD getting access to the ai core is a coding balance PR that is out of scope of this one.
The extra visibility from the corridor makes the upload secure enough for it to have windows.
Gravgen and board storage was moved only to make space for the upload.
The Tcomms airlocks are just the same ones that you can find on most of the other maps

Keep in mind that this will get testmerged before and if a proper merge will be done. We will have time to test this out and resolve any further issues then.

Changes I made:
Removed two turrets from core
vivaldi_sM7gYS4EHb

Added two windows to tcomms from the bridge
vivaldi_uoqOa3Ysce

Replaced the alert and power console in sat with ai integrity restorer and cyborg control console

@MegaEmpirical
Copy link

The symmetry issues:

Either have all the buses towards the center or towards the exterior and move the middle servers inward so that bus and processor are adjacent and can aligned with the above buses and processors.

@Moja10
Copy link
Contributor

Moja10 commented May 20, 2020

I don't think there's a problem with the AI being at the center, the problem is that the AI core in the center's current design sucks and is too vulnerable to any powergamer's numerous ways of killing/teleporting/deleting/blocking the AI with the AI having no response aside from help from a borg. There's a /tg/ PR where they moved the AI core BACK to the center of the station after having moved it to the satellite, and their AI core design on box at the center of bridge is much better than our current design and I keep suggesting this over moving the AI core to the satellite.

@smorgli
Copy link
Contributor Author

smorgli commented May 20, 2020

I don't think there's a problem with the AI being at the center, the problem is that the AI core in the center's current design sucks and is too vulnerable to any powergamer's numerous ways of killing/teleporting/deleting/blocking the AI with the AI having no response aside from help from a borg. There's a /tg/ PR where they moved the AI core BACK to the center of the station after having moved it to the satellite, and their AI core design on box at the center of bridge is much better than our current design and I keep suggesting this over moving the AI core to the satellite.

I didn't know anything about this, this is the PR:
tgstation/tgstation#50740

I actually kind of like the idea and might do a similar thing instead if my change does not get accepted.

@MacHac
Copy link
Contributor

MacHac commented May 20, 2020

TG's new center design is somewhat better than ours in that it takes longer than 3 minutes to breach the core and block the turrets with nothing but a toolbelt, but it's still vulnerable to all sorts of very fast AI kills. Plus, attaching the upload to the bridge is the sort of temptation that most of our Captain mains don't need.

TG isn't moving the AI back inside because it's a good decision, they're moving it inside to help distinguish it from Meta. Most of our server can't find their way around Meta anyway, so it's not something we need to be worrying about.

@boodaliboo
Copy link
Contributor

new bad

@Marmio64
Copy link
Contributor

rip nukies

@ThatLing ThatLing added the Controversial People are divided on this PR label May 24, 2020
@smorgli
Copy link
Contributor Author

smorgli commented May 24, 2020

Moved the comms apc so it cant be ioned through the bridge, upload has better turret placement now, removed the pump for sat waste, board storage now has plating instead of floor tiles, other minor tweaks.

Upload:
vivaldi_G0bD6UYQcR

@smorgli
Copy link
Contributor Author

smorgli commented May 26, 2020

Adressing balance concerns, changed the ai core a bit, made some walls in sat not reinforced.
New look:
dreamseeker_U31jsoG7FG
dreamseeker_crZeLOECBL

Copy link
Contributor

@Ktlwjec1 Ktlwjec1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye i dont want this sitting for years and im fine with it

@Ktlwjec1 Ktlwjec1 merged commit 4cc733d into yogstation13:master Jun 6, 2020
@smorgli smorgli deleted the Branch_7b24b9cc_2 branch June 14, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Controversial People are divided on this PR Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet