Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalances Security Grenades #8598

Merged
merged 3 commits into from Jun 21, 2020

Conversation

MacHac
Copy link
Contributor

@MacHac MacHac commented May 20, 2020

Intent of your Pull Request

Flashbangs are currently very strong and tear gas is very weak. I've tried to balance the two with feedback from people who play more security than I do.

Flashbangs

Flashbangs are now more forgiving if you have only one type of protection (eye or ear.) Being exposed to a flashbang without ear protection will cause a few seconds of confusion after the stun ends. I'm trying to narrow its niche to opening an assault and forcing people out of cover, just like real flashbangs.

No protection
  • Maximum stun length: 15s (down from 20s)
  • Minimum stun length: 6s (unchanged)
Eye protection only
  • Maximum stun length: 5s (down from 20s)
  • Minimum stun length: 3s (down from 6s)
  • Confusion: Up to 20s, decreases asymptotically with distance
Ear protection only
  • Maximum stun length: 5s (down from 20s)
  • Minimum stun length: 3s (down from 6s)
  • Blindness: 3s (unchanged)
Full protection
  • No effect (unchanged)

Tear Gas

In addition to its old effects, tear gas now lingers in the system causing stamina damage and coughing. The cloud is unlikely to stamcrit directly unless the victim doesn't try to leave at all, but more than a few seconds of exposure will cause people to drop their items and move more slowly for a while. The caveat is that officers are vulnerable to the smoke as well; Thus, the grenades are best for weakening fortified antagonist bases and covering retreats.

I'll consider adding tear gas to the secvend if enough people think it's a good idea, vote now in the comments.

  • Even though I'm buffing condensed capsaicin, pepper spray delivers so little that it's almost unaffected.

Why?

The flashbang is the lord and savior of medium range combat; if you can count to four you hardly even have to click on the enemy. The obnoxious stun length is made more obnoxious by the fact that you have to get two separate counter items to survive, one of which is semi-obscure and not used for anything else. There may be room in your galaxy-sized brain for the location of every bowman on the station, but newer antags don't deserve instant death just because someone managed to land a click in their zip code.

By contrast, tear gas is hardly worth the inventory space. Masks block it partially and any sort of glasses block it completely, so it's essentially a glorified smoke grenade. It's hard to use effectively and easy to counter.

With these changes, both grenades get a unique and useful tactical niche without being overbearing. The flashbang disrupts any waiting enemies as you breach a room and forces people in cover to pull back; Tear gas softens up fortified enemies and creates cover for movement or retreat. Both of these roles roughly match their real-life analogues, though that alone isn't justification for a balance decision.

I've tuned all the numbers based on what 'felt right' compared to normal combat; if something seems too high or too low, I'm open to change.

Changelog

馃啈
tweak: The Space Geneva Convention has taken action against grenades of mass destruction; Flashbang payloads have been adjusted down in compliance.
tweak: NT officials noticed that the shipments marked 'tear gas' contained nothing but red food coloring and have found a new supplier.
/:cl:

@yogstation13-bot yogstation13-bot added the Tweak This PR contains changes to the game. label May 20, 2020
if(!distance || loc == M || loc == M.loc) //Stop allahu akbarring rooms with this.
M.Paralyze(200)
M.soundbang_act(1, 200, 10, 15)
M.soundbang_act(1, 20, 10, 15)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means if you're on top of the flashbang when it goes off, you will be stunned for far less.

This lets you be a flashbang suicide bomber again, basically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually changed the definition of soundbang_act. Paralyze() works in deciseconds, but confusion works in seconds. You can see in the code that I changed every other use of the function too.

Flashbang suicide bombing is degenerate but 200 seconds of confusion is a step too far. Of course, since it completely overlays the stun, it'll only affect someone with stun reduction.

Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atomize your prs, move the tear gas changes to another pr so it can be discussed about on its own

@MacHac
Copy link
Contributor Author

MacHac commented May 20, 2020

I bundled the two over balance concerns. Some people I talked to encouraged me to make a compensatory buff, but any security change (buff or nerf) tends to spawn 100-comment 'insightful discussions'. I hoped that doing the two under the same PR would paint the change as being tit-for-tat rather than a salty security main/ided PR.

Besides, 'security grenades' is almost atomic. Call it a molecular PR. I'm willing to split it if you think it's necessary, but first understand why I'm not eager to do so.

@SomeguyManperson
Copy link
Contributor

confusion is a mob stat that's handled on life() so 1 confusion actually lasts ~2 seconds

@athena413
Copy link
Contributor

ohhhh my god yes

@MegaEmpirical
Copy link

Tear gas is easily avoided unfortunately, though the buff is nice.

I think the 3 second minimum stun is too low, the current max is admittedly high.

@MacHac
Copy link
Contributor Author

MacHac commented May 21, 2020

The tear gas is really an area denial tool more than an offensive weapon; it's not hard to stay clear, but if you grit your teeth and try to run through you'll end up in damage slowdown. Being easy to avoid works in your favor with tactical use: chuck one into the gang base then grab them as they come running out.

The three second minimum stun is what you get if you're 5 tiles from the flashbang when it goes IE there are 4 empty tiles of space between you and it. Security getting a free followup stun even at that range is most of the problem with flashbangs in the first place.

Flashbangs as a primary capture tool is the behavior I want to discourage. Their intended niche is to force people out of cover and disrupt enemy defenses, not be a single use overpowered stun baton.

@alexkar598 alexkar598 added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 21, 2020
@MegaEmpirical
Copy link

Ahh I see. Well I'm definitely interested in testing this

@Firewolf34
Copy link
Contributor

I like your Changelog entries.

@alexkar598 alexkar598 added Awaiting - Action - Author This PR is awaiting an action from the author and removed Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer labels Jun 19, 2020
@JamieD1 JamieD1 removed the TESTMERGE label Jun 20, 2020
@alexkar598 alexkar598 merged commit a479c5f into yogstation13:master Jun 21, 2020
Yogbot-13 added a commit that referenced this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants