Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel shifting fixes 2 #8621

Merged
merged 3 commits into from Jun 14, 2020
Merged

Pixel shifting fixes 2 #8621

merged 3 commits into from Jun 14, 2020

Conversation

ReddicusDragon
Copy link
Contributor

Ports pixelshifting reset code, also fixes ais being able to pixelshift
馃啈
rscadd: Pixel shifting now automatically resets when a player moves
rscdel: AIs cannot pixelshift
bugfix: AIs cannot pixelshift
/:cl:

@yogstation13-bot yogstation13-bot added Feature This adds new content to the game Revert / Deletion Altoids is probably mad about this labels May 21, 2020
@boodaliboo
Copy link
Contributor

dumb stupid pr ruining fun

@Jarod1200
Copy link

Pixel shiting is important for ais to communicate with things that don't speak common, preternis, or lizard

Hopekz
Hopekz suggested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@Hopekz Hopekz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atomize your PR.
Making the AI not being able to pixelshift at all and putting in a reset for pixelshifting after the pixel shift are 2 separate PR's

@boodaliboo
Copy link
Contributor

Atomize your PR.
Making the AI not being able to pixelshift at all and putting in a reset for pixelshifting after the pixel shift are 2 separate PR's

atomize i tagree

@Hopekz Hopekz added the Awaiting - Action - Author This PR is awaiting an action from the author label May 23, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented May 27, 2020

@ReddTheDragon

@JamieD1 JamieD1 added the Stale I'm closing this in like a week if you don't push a new commit label Jun 5, 2020
@alexkar598 alexkar598 merged commit eec1c72 into yogstation13:master Jun 14, 2020
@yogstation13-bot yogstation13-bot added the Fix This fixes an issue. Please link issues in fix PRs label Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hopekz Hopekz Hopekz requested changes

@alexkar598 alexkar598 alexkar598 approved these changes

Assignees
No one assigned
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Revert / Deletion Altoids is probably mad about this Stale I'm closing this in like a week if you don't push a new commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ReddicusDragon @boodaliboo @Jarod1200 @JamieD1 @Hopekz @alexkar598 @yogstation13-bot