Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives cyborgs use of respective radio channels (TG Port) #8678

Merged
merged 2 commits into from
May 26, 2020

Conversation

Jumps0
Copy link
Contributor

@Jumps0 Jumps0 commented May 24, 2020

Intent of your Pull Request

All credit to the original coder Kelenius.
tgstation/tgstation#51222

"Gives the cyborgs access to their department's radio:

  • Medical gets medical.
  • Engineering gets engineering.
  • Service and Janitor get service.
  • Mining gets supply and science.
  • Security gets security. In case it's enabled, spawned, etc.
  • Peacekeeper gets service to find out where to tactically deliver cookies.
  • Clownborg gets service because clown.
  • Standard gets nothing. Pick a side, filthy centrist.

This channel is not related to the encryption key that can be installed into any cyborg and works in addition to they key, if installed.

I didn't touch the syndicate cyborgs, they still use an encryption key. I don't want to mess with radio code more than necessary and their encryption key already gives them everything they want, so it's unlikely someone will ever mess with it. Not broken, no fixes."

Changelog

馃啈 Kelenius
rscadd: Cyborgs (except Standard) now have access to their department's radio.
/:cl:

@yogstation13-bot yogstation13-bot added the Feature This adds new content to the game label May 24, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented May 24, 2020

I suggested this ages ago,

What I was told is the ai should be telling you what to do and where to go not departments,

But im ALL for this change.

@Jumps0
Copy link
Contributor Author

Jumps0 commented May 24, 2020

I completely understand the argument for "it's the job of the AI to relay messages for the borg". But that's honestly a lot of work for the AI to do that IMO shouldn't really be necessary because they have better things to do. Seeing engi borgs drag a headset to robo and ask for the chip to be installed seems like an example of this "messenger" problem, so I feel like this is a needed change. Additionally these are the votes on the original TG PR:
image

@jcatjmeow
Copy link
Contributor

"it's the job of the AI to relay messages for the borg" is a fucking stupid argument because borgs can have robos give them radio keys anyway, if that really was true that wouldn't be a thing

@ynot01
Copy link
Contributor

ynot01 commented May 25, 2020

should probably give peacekeeper service

Copy link
Contributor

@Hopekz Hopekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positive reception.
Code checks out.
Merge time.

@Hopekz Hopekz merged commit 1e0d205 into yogstation13:master May 26, 2020
@Jumps0 Jumps0 deleted the cyborgradio branch May 26, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants