Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds eggman to charged black and magic mirror and prides mirror #8736

Merged
merged 2 commits into from Jun 14, 2020
Merged

adds eggman to charged black and magic mirror and prides mirror #8736

merged 2 commits into from Jun 14, 2020

Conversation

boodaliboo
Copy link
Contributor

@boodaliboo boodaliboo commented May 28, 2020 •
edited by JamieD1

there not op so why not

Changelog

馃啈
rscadd: adds eggman to charged black and magic mirror and prides mirror
/:cl:

@yogstation13-bot yogstation13-bot added the Feature This adds new content to the game label May 28, 2020
Hopekz
Hopekz suggested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@Hopekz Hopekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your changelog.
Current: "rscadd: egg <@250285065039380481>"

@smorgli
Copy link
Contributor

smorgli commented May 28, 2020

Maybe update the comment in the file

@JamieD1 JamieD1 added the Awaiting - Action - Author This PR is awaiting an action from the author label May 31, 2020
alexkar598
alexkar598 previously requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment

JamieD1
JamieD1 requested changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@JamieD1 JamieD1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your changelog

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 5, 2020

@boodaliboo

@boodaliboo
Copy link
Contributor Author

Fix your changelog

what?

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 6, 2020

Fix your changelog

what?

Fix your changelog... its has <@250285065039380481> in it

@boodaliboo
Copy link
Contributor Author

Fix your changelog

what?

Fix your changelog... its has <@250285065039380481> in it

that was to tag someone on discord on creation of the pr. it was colburn

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 11, 2020

Fix your changelog

what?

Fix your changelog... its has <@250285065039380481> in it

that was to tag someone on discord on creation of the pr. it was colburn

Please just remove it and ill suggest its merged.

@Hopekz
Copy link
Contributor

Hopekz commented Jun 12, 2020

Fix your changelog

what?

Fix your changelog... its has <@250285065039380481> in it

that was to tag someone on discord on creation of the pr. it was colburn

Please just remove it and ill suggest its merged.

Maintainers or whoever merges it can just modify that right before a merge once they are aware of it.

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 12, 2020

Fix your changelog

what?

Fix your changelog... its has <@250285065039380481> in it

that was to tag someone on discord on creation of the pr. it was colburn

Please just remove it and ill suggest its merged.

Maintainers or whoever merges it can just modify that right before a merge once they are aware of it.

I know, I have sent this to alexkar with the note to edit the changelog

@JamieD1 JamieD1 dismissed alexkar598鈥檚 stale review June 14, 2020 16:11

It has been done

@JamieD1 JamieD1 merged commit d77162e into yogstation13:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hopekz Hopekz Hopekz requested changes

@JamieD1 JamieD1 JamieD1 approved these changes

@alexkar598 alexkar598 alexkar598 left review comments

Assignees
No one assigned
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Feature This adds new content to the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@boodaliboo @smorgli @JamieD1 @Hopekz @alexkar598 @yogstation13-bot