Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds (a smaller) pAI button back to ghost hud #8740

Merged
merged 3 commits into from Jun 8, 2020

Conversation

Jumps0
Copy link
Contributor

@Jumps0 Jumps0 commented May 28, 2020

Intent of your Pull Request

Requested by @wejengin2
Add's the pAI button back that was recently swapped out by another one of my PRs. (Though smaller this time)
This does not remove the ghost role button it simply just puts the pAI button back on the HUD.
pai

Thanks to JamieD1 for the smaller pAI sprite. <3

Changelog

馃啈
tweak: Adds (a smaller) pAI button back to ghost hud
/:cl:

@yogstation13-bot yogstation13-bot added the Tweak This PR contains changes to the game. label May 28, 2020
@alexkar598
Copy link
Member

I'd have have a link to sign up in the ghost pai notification instead of a fifth button

@Jumps0
Copy link
Contributor Author

Jumps0 commented May 28, 2020

I'd have have a link to sign up in the ghost pai notification instead of a fifth button

A link where? Inside the ghost role options?

@JamieD1
Copy link
Contributor

JamieD1 commented May 31, 2020

I'd have have a link to sign up in the ghost pai notification instead of a fifth button

Thing is if you submit personalities then it sends a ping to the devices, if you take that away it will be only one way.

@alexkar598
Copy link
Member

Make it a verb in the right hand panel instead. We are quickly going to get the menu cluttered if we keep adding buttons like that

@Jumps0
Copy link
Contributor Author

Jumps0 commented Jun 3, 2020

Make it a verb in the right hand panel instead. We are quickly going to get the menu cluttered if we keep adding buttons like that

verb
it's been a verb. If you feel like this button PR is unnecessary then you can close it.

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 4, 2020

Make it a verb in the right hand panel instead. We are quickly going to get the menu cluttered if we keep adding buttons like that

verb
it's been a verb. If you feel like this button PR is unnecessary then you can close it.

How about if you add it a small button underneath he speech bubble?

This would not clutter the menu and keep it looking nice :)

@JamieD1 JamieD1 added the Awaiting - Action - Author This PR is awaiting an action from the author label Jun 5, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented Jun 5, 2020

@Jumps0

@Jumps0
Copy link
Contributor Author

Jumps0 commented Jun 6, 2020

seems do-able, though downscaling the sprite is gonna be tricky cause i'm not a good spriter
image

I'll try to do it tomorrow

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 6, 2020

Hows this?
Small Pai

@Jumps0 Jumps0 changed the title Adds pAI button back to ghost hud Adds (a smaller) pAI button back to ghost hud Jun 6, 2020
@Jumps0 Jumps0 requested a review from JamieD1 June 6, 2020 15:49
@github-actions github-actions bot added the Sprites This PR has spriting changes label Jun 6, 2020
@Jumps0
Copy link
Contributor Author

Jumps0 commented Jun 6, 2020

Jamie wanted it moved so i moved it

@alexkar598
Copy link
Member

This is small enough to be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Sprites This PR has spriting changes Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants