Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolathe 2.1 - Fucking Performance Edition #8770

Closed
wants to merge 1 commit into from
Closed

Autolathe 2.1 - Fucking Performance Edition #8770

wants to merge 1 commit into from

Conversation

JamieD1
Copy link
Contributor

@JamieD1 JamieD1 commented May 31, 2020 •
edited

Intent of your Pull Request

Will be merged in with TGUI Change #8291

Changelog

馃啈
bugfix: Fixed being able to autolathe with panel open
tweak: Improved autolathe performance
/:cl:

@yogstation13-bot yogstation13-bot added Fix This fixes an issue. Please link issues in fix PRs Javascript This PR contains javascript code. Tweak This PR contains changes to the game. labels May 31, 2020
@github-actions github-actions bot added the tgui This PR affects TGUI label May 31, 2020
@smorgli
Copy link
Contributor

smorgli commented May 31, 2020

Could have just reversed it

@JamieD1
Copy link
Contributor Author

JamieD1 commented May 31, 2020

Could have just reversed it

REEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE

@TheGamerdk
Copy link
Contributor

now you just need ui_static_data for MAXIMUM power

@JamieD1
Copy link
Contributor Author

JamieD1 commented May 31, 2020

now you just need ui_static_data for MAXIMUM power

Too hard, I tried.

@JamieD1 JamieD1 added the DO NOT MERGE Should not be merged without express approval from a Head Dev label Jun 1, 2020
@TheGamerdk TheGamerdk mentioned this pull request Jun 1, 2020
Merged
6 tasks
alexkar598
alexkar598 requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@alexkar598 alexkar598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the regex, its a barely noticable feature but it can get a bit expensive to run without mentionning the fact that you cant write all characters( like ( needs to be escaped )

@JamieD1
Copy link
Contributor Author

JamieD1 commented Jun 5, 2020

Remove the regex, its a barely noticable feature but it can get a bit expensive to run without mentionning the fact that you cant write all characters( like ( needs to be escaped )

It was one of the most requested features with the new ui :(

@JamieD1
Copy link
Contributor Author

JamieD1 commented Jun 11, 2020

Included in tgui 3.0

@JamieD1 JamieD1 closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkar598 alexkar598 alexkar598 requested changes

Assignees
No one assigned
Labels
DO NOT MERGE Should not be merged without express approval from a Head Dev Fix This fixes an issue. Please link issues in fix PRs Javascript This PR contains javascript code. tgui This PR affects TGUI Tweak This PR contains changes to the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autolathes still build while their panel is open
5 participants
@JamieD1 @smorgli @TheGamerdk @alexkar598 @yogstation13-bot