Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlocks don't feel clunky anymore #8811

Merged
merged 4 commits into from Jun 21, 2020
Merged

Conversation

Hopekz
Copy link
Contributor

@Hopekz Hopekz commented Jun 5, 2020

This ancient airlock code hasn't been touched for 3 years.

Before:

9ptsUpqXBI

After:

EDIT:

Fine-tuned the speed as it looked too early initially.

Here is how it looks now:
2Cgm6W0LwM

EDIT 2:

Per Monster's suggestion did the same thing to closing doors.

Before:
gAS4sIeGQD

After:
a6F5eom0W0

Changelog

馃啈 Hopek
tweak: Makes airlocks feel less clunky by allowing you to walk through them when they're open on-screen vs when the full animation is done.
tweak: Makes airlocks feel even less clunky by allowing you to walk through them while closing when the on-screen animation has a gap VS you crashing into an invisible wall as soon as the animation starts.
/:cl:

@yogstation13-bot yogstation13-bot added the Tweak This PR contains changes to the game. label Jun 5, 2020
@ynot01
Copy link
Contributor

ynot01 commented Jun 5, 2020

hmm

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 5, 2020

EDIT:

Fine-tuned the speed as it looked too early initially.

Here is how it looks now:
2Cgm6W0LwM

@johnnyboyz25
Copy link

Make fat people wait for the animation to finish

@monster860
Copy link
Member

can you do the same with doors closing

Who knew 1 decisecond is all it needed to be smooth
@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 5, 2020

Make fat people wait for the animation to finish

Out of scope for this PR.
I'll PR it after this one is merged because it might be controversial.

can you do the same with doors closing

Alright. Done.

Before:
gAS4sIeGQD

After:
a6F5eom0W0

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 5, 2020

Have you checked if its easier or harder to crush people as ai now?..

@Hopekz
Copy link
Contributor Author

Hopekz commented Jun 5, 2020

Have you checked if its easier or harder to crush people as ai now?..

I'd imagine it's easier because now people have more opportunities to be under a door instead of being blocked by an invisible wall.

@jcatjmeow
Copy link
Contributor

jcatjmeow commented Jun 6, 2020

Personally I'd make it so you have to wait just a moment on the closing, cause right now the sprite player clips through the door for a bit. But I like this as is better than the default so idk

@JamieD1 JamieD1 added the Test Merge - Scheduled This PR is waiting to be test merged label Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Merge - Scheduled This PR is waiting to be test merged Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants