Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates all the space suits #8822

Merged
merged 5 commits into from Jun 14, 2020
Merged

Updates all the space suits #8822

merged 5 commits into from Jun 14, 2020

Conversation

grimm-hollowknight
Copy link
Contributor

Edits, adds, and removes some space suits.

Edits:

  • all the space suits with improvements to colours
  • the paramedic to spacesuit to be consistent with the new spacesuits and remove its armoured appearance
  • the black and red, medical, and engineering syndicate space suits to stand out and look more interesting
  • the command EVA suit to be consistent with the new designs

Adds:

  • a cosmonaut space suit. needs to be implemented at some point
  • a new sprite ported from Tau Ceti for the EVA suit.
  • an emergency space suit with very limited resistances and has a chance to become torn when the wearer is attacked, was previously unused. needs to be implemented at some point

Removes:

  • several syndicate space suits that had uninteresting designs and were unused
  • The EVA suit path, now merged with the base path

Changelog

馃啈 grimm hollow knight
rscadd: A new space suit, the Cosmonaut space suit. Currently unattainable.
bugfix: The command space suit only protected from flashes, but now has welding protection as all space suits do.
imageadd: Several edits to the new space suit sprites.
imageadd: A new sprite for the paramedic to space suit to show it is not armored.
imageadd: A new sprite for the command space suit.
imageadd: A new sprite the for EVA suit ported from Tau Ceti.
imagedel: Removes unused syndicate space suit designs.
tweak: Moves all hardsuit code in the spacesuit file to the hardsuit file.
spellcheck: Renames the Shielded Deathsquad Mk3. SWAT suit to Death commando hardsuit from Death command space suit because it is very clearly a hardsuit even though it stated it was a space suit in a comment which is false.
/:cl:

@yogstation13-bot yogstation13-bot added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Icon Change Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Jun 5, 2020
@github-actions github-actions bot added the Sprites This PR has spriting changes label Jun 5, 2020
@Marmio64
Copy link
Contributor

Marmio64 commented Jun 5, 2020

we're gonna force you to atomize every single addition and edit, sorry kid, gonna have to make 4599488 PRs now.

@Hopekz
Copy link
Contributor

Hopekz commented Jun 5, 2020

Paramedic spacesuit has a red cross on the back sprite

image

@ynot01
Copy link
Contributor

ynot01 commented Jun 5, 2020

id love to see this testmerged

who knows if they give a fuck about what the players think though

Copy link
Contributor

@JamieD1 JamieD1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the following map files:
DJstation.dmm : 100/101
crashedship.dmm:2219-2222
lavaland_surface_xeno_nest.dmm:155-157
wildwest.dmm:2048-2049
challenge.dmm:28-29, 60-61, 72-73
moonoutpost19.dmm:1885,1888,2061-2063

@grimm-hollowknight
Copy link
Contributor Author

Paramedic spacesuit has a red cross on the back sprite

image

yeah i know i put it there

id love to see this testmerged

who knows if they give a fuck about what the players think though

this doesnt need a testmerge

@Partheo
Copy link
Contributor

Partheo commented Jun 6, 2020

Paramedic suit is way better.

I trust you with any removals so the fat trimming doesn't bother me at all.

Clothing sprites are like black magic to me, seeing you replace an ever more significant portion of them is quite inspiring.

image
My one issue with this design is the lack out outline on the sole of the feet. This can lead to cases where the feet blend in with what they're standing on. A clear distinction between the floor and the mob is important IMO. Drawing soles is a very easy way to add nontrivial detail to a shoe/boot sprite.

@Partheo
Copy link
Contributor

Partheo commented Jun 6, 2020

soul detected

@JamieD1 JamieD1 merged commit 9f00ae1 into yogstation13:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Sprites This PR has spriting changes Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants