New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redoes KMC's ticket machine and allows it to be built. #8833
Conversation
Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com>
Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com>
I can code it so your ticket buzzes when it's your turn. Y/N? TG has that feature as far as I'm aware |
Buzzer is a good thing imo as long as you keep the ticket in your inventory. |
@jcatjmeow - The machine is a standard feature of Eclipse Station, should not be removed. |
Thanks for reminding me! However, you reminded me that the actual ticket machine was on eclipse as well! This is no good because the ticket machine behavior has been re-written and now it would be stuck in a wall, yucky! I have removed it as well. If you want to have a ticket machine on eclipse station, just build one! The boards and remote can be printed roundstart from the cargo or service or medbay lathes. The machine does not require any expensive components either! |
Removing from Eclipse is no good, port (PR #6884) was specifically to have working ticket machine at round start on Eclipse. Do not support unless the machine is added to Eclipse. This is a wider issue than the ticket machine specifically. If coders change things that are extant on other maps (for whatever reason) they need to maintain the changes to those maps. "Just build one!" is not an excuse for lax maintenance. |
Ok this should be ready to go then! |
Well put-together PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below:
Also:
machine_designs.dm -> list ( to list(
misc_designs.dm -> list ( to list(
math spacing -> ticketmachine.dm 148-150
Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com>
Best PR ever |
Intent of your Pull Request
Requested by @Jarod1200
Re-adds and redoes KMC's ticket machine!
Features:
This has been tested, and I went through and added a football field of whitespace before and after every single character, for JameiD1's benefit :3
Picture!
Changelog
Original pr by KMC The sounds from this pr are the same but a lot of other stuff has changed so keep that in mind
🆑
rscadd: The ticket machine is back, and it and plays better than ever! Build it at your local service, medbay, or cargo lathe!
imageadd: beautiful sprites by KMC, with overlays by Jcat, and help from Partheo
/:cl: