Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurora Caelus rework #8886

Closed
wants to merge 12 commits into from
Closed

Conversation

ynot01
Copy link
Contributor

@ynot01 ynot01 commented Jun 12, 2020

Intent of your Pull Request

Instead of doing like fucking nothing lol
it now is a meteor wave that shoots harmless ion bolts at the station, like described

new sprite (uncolored)

Changelog

馃啈
tweak: Aurora Caelus event reworked
/:cl:

@yogstation13-bot yogstation13-bot added DME Edit This PR affects the yogstation.DME file Tweak This PR contains changes to the game. labels Jun 12, 2020
@jcatjmeow
Copy link
Contributor

ok so I downloaded your pr and tested the event.

  1. the ending message plays twice. Once in the middle of the song, and once again as the song is ending.
  2. no ions/meteors spawn of any kind.

This needs further work

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 12, 2020

Its supposed to be pretty :( not blue boring ions

@ynot01
Copy link
Contributor Author

ynot01 commented Jun 12, 2020

Its supposed to be pretty :( not blue boring ions

120% of players report that they dont see shit on aurora, now they'll see shit

@Marmio64
Copy link
Contributor

Its supposed to be pretty :( not blue boring ions

120% of players report that they dont see shit on aurora, now they'll see shit

could you make the ion bolts greyscale and just have em pick colors like green, red, blue, and yellow?

@ynot01
Copy link
Contributor Author

ynot01 commented Jun 13, 2020

Its supposed to be pretty :( not blue boring ions

120% of players report that they dont see shit on aurora, now they'll see shit

could you make the ion bolts greyscale and just have em pick colors like green, red, blue, and yellow?

ill try working on this tomorrow

@JamieD1 JamieD1 added the Awaiting - Action - Author This PR is awaiting an action from the author label Jun 17, 2020
@SuperTeaLove
Copy link
Contributor

I like the current subtle glow but I do agree its visually uninteresting and if it doesn't function without parallax then that's definitely an issue. I don't really like this method of tackling it though and would prefer the current subtle prettiness over ions smacking the station, even if its more accurate to the flavor text.

@ynot01 ynot01 requested a review from Partheo as a code owner June 22, 2020 00:43
@github-actions github-actions bot added the Sprites This PR has spriting changes label Jun 22, 2020
code/game/gamemodes/meteor/meteors.dm Outdated Show resolved Hide resolved
code/game/gamemodes/meteor/meteors.dm Outdated Show resolved Hide resolved
ynot01 and others added 2 commits June 21, 2020 21:32
Co-authored-by: jcatjmeow <40673387+jcatjmeow@users.noreply.github.com>
Co-authored-by: jcatjmeow <40673387+jcatjmeow@users.noreply.github.com>
Co-authored-by: jcatjmeow <40673387+jcatjmeow@users.noreply.github.com>
Copy link
Contributor

@jcatjmeow jcatjmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't mean very much but I approve

@JamieD1
Copy link
Contributor

JamieD1 commented Jun 22, 2020

@ynot01 Gifs!

@ynot01
Copy link
Contributor Author

ynot01 commented Jun 23, 2020

@ynot01 Gifs!

i gave you a bloody gif what more do you want

@TheGamerdk
Copy link
Contributor

Why don't you keep the original aurora too

@Firewolf34
Copy link
Contributor

Firewolf34 commented Jun 27, 2020

Yeah I would say... Please keep the original aurora event and add this to it if you're doing this

dropamt = 1

/obj/effect/meteor/aurora/Initialize(mapload, target)
. = ..()
Copy link
Contributor

@jcatjmeow jcatjmeow Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. = ..()
. = ..()
var/xxx = round(world.maxx/2)
var/yyy = round(world.maxy/2)
chase_target(locate(xxx, yyy, 2))

This will make each bolt go towards the center of the station. It might not be the best but it does help more of them hit the windows.

I've also been asked to see if you would consider keeping the old event stuff too. Like the color changes to the starlight.

@Sun-Soaked
Copy link

just add these bolts to the old aurora, instead of replacing it.

@ynot01
Copy link
Contributor Author

ynot01 commented Jul 14, 2020

im sorry i abandoned this ill reopen when i get the motivation

@ynot01 ynot01 closed this Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Author This PR is awaiting an action from the author DME Edit This PR affects the yogstation.DME file Sprites This PR has spriting changes Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants