Smooth Doors #8901
Merged
Smooth Doors #8901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we see what regular airlocks look like too |
|
Show us what the other airlock types look like too, especially regular airlocks as they are the most common and will end up being like 90% of what this PR is changing |
|
I actually like the regular door movements, in the new gif you posted. I wasn't sure about it at first but it looks quite good. Strongly dislike the animated hatch though. Rotating pixels is an artistic warcrime. |
Partheo
suggested changes
Jun 20, 2020
JamieD1
approved these changes
Jul 7, 2020
Yogbot-13
added a commit
that referenced
this pull request
Jul 7, 2020
This was referenced Jul 9, 2020
|
Damn that took a while :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, doors have animated icon_states which are often at ~10 fps. This PR replaces this model with a model of having a left side and right side, or in more complicated cases (such as the abductor door with 7 parts!) more, and animating them to move, allowing the thing to be silky-smooth
Gif of all the doors:
Gif of hatch:
馃啈 monster860
tweak: Doors are now smoother
/:cl: