Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lavaland comms now has proper cooling - SYNDICATE EDITION #8926

Merged
merged 4 commits into from Jun 23, 2020

Conversation

MrHorizons
Copy link
Contributor

@MrHorizons MrHorizons commented Jun 16, 2020

Due to the merging of #8836, my homies in the Syndicate have told me it'd be in my best interests to make this PR.

Before

image

After

image

Changelog

🆑
tweak: The Syndicate's Lavaland telecomm relay now generates heat. It has been outfitted with a simple cooling system to compensate.
/:cl:

…es heat. A basic cooling setup has been implemented to compensate.
@yogstation13-bot yogstation13-bot added Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Jun 16, 2020
@MrHorizons MrHorizons marked this pull request as draft June 16, 2020 03:10
@MrHorizons MrHorizons marked this pull request as ready for review June 16, 2020 03:11
@smorgli
Copy link
Contributor

smorgli commented Jun 16, 2020

consistency good

Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that tcomms turfs are different then regular ones in case you didn't know.
Maybe try to arrange it in a way that makes the pipe not be under a window, ktl hates that.
Also make sure to add a helper to the airlocks so they cycle properly.
And throw a space heater in there somewhere, maybe maint?

@MrHorizons
Copy link
Contributor Author

Reminder that tcomms turfs are different then regular ones in case you didn't know.
Maybe try to arrange it in a way that makes the pipe not be under a window, ktl hates that.
Also make sure to add a helper to the airlocks so they cycle properly.
And throw a space heater in there somewhere, maybe maint?

They are already tcomm turfs, so you don't have to worry about that. Though I will make the latter three changes.

Copy link
Contributor

@Ktlwjec1 Ktlwjec1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use cyclelink_helper_target on the airlocks instead, and set the dirx and diry values to target the other airlock for each.

@MrHorizons
Copy link
Contributor Author

MrHorizons commented Jun 21, 2020

You need to use cyclelink_helper_target on the airlocks instead, and set the dirx and diry values to target the other airlock for each.

Ah, I see. I have replaced the cyclelink_helpers with the cyclelink_helper_targets, hopefully resolving this issue.

@JamieD1 JamieD1 added Awaiting - Action - Author This PR is awaiting an action from the author WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on. labels Jun 21, 2020
Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The room needs a separate special tcomms air alarm for the air flow to work. Make sure to set req_access.txt to 150
  2. The turf under the window needs to be a plating.
  3. I see no reason not to keep the relay itself on use_power=0 , put it back just in case.
  4. Your cyclelinks are set to "1" and "0" instead of 1 and 0

@smorgli smorgli removed the WORK IN PROGRESS This PR will take a while before its complete, but is actively being worked on. label Jun 22, 2020
@smorgli smorgli added Awaiting - Merge This PR is ready for merge and removed Awaiting - Action - Author This PR is awaiting an action from the author labels Jun 22, 2020
@smorgli smorgli requested a review from Ktlwjec1 June 22, 2020 17:55
Copy link
Contributor

@Ktlwjec1 Ktlwjec1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing and then it's fine to merge:
Since it has its own air alarm now, you'll need to create a new area in "code/game/area/areas/ruins/lavaland.dm" and make that room have that area. Otherwise there's no point in having the air alarm, since it can just be accessed from the one in the room right of it. Add a fire alarm into the room (on the freezer side) when you do that too.

@Ktlwjec1 Ktlwjec1 added Awaiting - Action - Author This PR is awaiting an action from the author and removed Awaiting - Merge This PR is ready for merge labels Jun 23, 2020
Copy link
Contributor

@Ktlwjec1 Ktlwjec1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm ignore me

@Ktlwjec1 Ktlwjec1 merged commit e9e359a into yogstation13:master Jun 23, 2020
Yogbot-13 added a commit that referenced this pull request Jun 23, 2020
@MrHorizons MrHorizons deleted the SyndieLavalandCooling branch July 20, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Author This PR is awaiting an action from the author Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants