Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Jukebox Music #8943

Merged
merged 3 commits into from Jun 24, 2020
Merged

New Jukebox Music #8943

merged 3 commits into from Jun 24, 2020

Conversation

swissloaf
Copy link
Contributor

@swissloaf swissloaf commented Jun 17, 2020 •
edited

Intent of your Pull Request

Adds new songs to the jukebox,

Eurobeat1 (https://youtu.be/PmObmXQxxJ0) MODIFED IN AUDACITY
Eurobeat2 (https://youtu.be/up6Nxg17opQ) MODIFED IN AUDACITY
Master of Puppets (https://youtu.be/_jYlloUKFmg) MODIFED IN AUDACITY
Calamity (https://youtu.be/17IZjvr5c1I)
PartyParty (https://youtu.be/4A1SiQkPqYM) MODIFED IN AUDACITY
Eurobeat3 (https://youtu.be/fxx5p8KnZ3w) MODIFIED IN AUDACITY
Cassette7 (https://youtu.be/MKKLwahE_J8)
Sandstorm (https://youtu.be/jWMTJ0oepCU)
that heyyayayayaya song from like 2009 (https://youtu.be/FR7wOGyAzpw)
wide putin song

Changelog

馃啈
rscadd: Adds new jukebox music
soundadd: Adds new ogg jukebox sounds
/:cl:

@yogstation13-bot yogstation13-bot added Feature This adds new content to the game Sound This PR changes audio files labels Jun 17, 2020
@swissloaf swissloaf added the Config Config files need to be changed on the host for this to work label Jun 17, 2020
@Hopekz
Copy link
Contributor

Hopekz commented Jun 17, 2020

Songs that aren't too good from these in my opinion (should probably be atomized like lobby music)

  • Eurobeat3
  • PartyParty

@swissloaf
Copy link
Contributor Author

Songs that aren't too good from these in my opinion (should probably be atomized like lobby music)

  • Eurobeat3
  • PartyParty

no

@JamieD1 JamieD1 requested a review from Partheo June 22, 2020 21:52
fluffe9911
fluffe9911 approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@fluffe9911 fluffe9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine needs to be added to config though

@JamieD1 JamieD1 merged commit a191e6d into yogstation13:master Jun 24, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented Jun 24, 2020

Added to Config

Yogbot-13 added a commit that referenced this pull request Jun 24, 2020
@Yogbot-13
Automatic changelog generation #8943 [ci skip]
1fd3281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffe9911 fluffe9911 fluffe9911 approved these changes

@Partheo Partheo Awaiting requested review from Partheo

Assignees
No one assigned
Labels
Config Config files need to be changed on the host for this to work Feature This adds new content to the game Sound This PR changes audio files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swissloaf @Hopekz @JamieD1 @fluffe9911 @yogstation13-bot