Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo transit tube pods #9153

Merged
merged 9 commits into from
Aug 20, 2020
Merged

Conversation

jcatjmeow
Copy link
Contributor

@jcatjmeow jcatjmeow commented Jul 7, 2020

Intent of your Pull Request

Tested!! Someone to look over the code for inefficiencies would be nice however.
Check it out bro
This here is a cargo transit tube pod!
(Note: vid is now a bit outdated. The pod sprite no longer does a sudden 180 when it reaches a terminus. Also, there are now sounds for loading/unloading)

Cargo here is not related to the cargo department. It just means that the pod carries cargo, not people (although it can carry people inside containers)

Cargo pods drop off and pick up containers like lockers, bodybags, and crates automatically. They also spend a little more than half the time at the station, compared to the regular pods. The downside is they cannot be climbed into by a person.

The pods will pick up and drop off containers at the tile where the pod's hinge is pointing to. If this is in a wall, instead it will drop off on the same tile as the station (in this case, it cannot pick anything up)

Other than the above, the pods function identically to the standard ones.

Happy transporting!!
Sprites done by @missatessatessy and yours truly!

Changelog

馃啈
rscadd: A new type of transit tube pod! Designed to carry cargo.
rscadd: Flipped tube stations can now be built with the RPD
/:cl:

@jcatjmeow jcatjmeow requested a review from Partheo as a code owner July 7, 2020 21:52
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Sprites This PR has spriting changes labels Jul 7, 2020
Copy link
Contributor

@Partheo Partheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprites are fine, I might make a PR to update them at another time (since the original is quite coderspritey)

@jcatjmeow jcatjmeow changed the title "Cargo transit tube pods" Cargo transit tube pods Jul 8, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented Jul 21, 2020

I spy a sleep proc.

@jcatjmeow
Copy link
Contributor Author

jcatjmeow commented Jul 21, 2020

I spy a sleep proc.

pre-existing. And we already talked about this. I can't replace it with a callback cause it needs to return something

@jcatjmeow jcatjmeow added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label Aug 17, 2020
Copy link
Contributor

@fluffe9911 fluffe9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fluffe9911 fluffe9911 merged commit 48201de into yogstation13:master Aug 20, 2020
Yogbot-13 added a commit that referenced this pull request Aug 20, 2020
@jcatjmeow
Copy link
Contributor Author

NOTE: If anyone has a way to remove the sleep procs without using a callback (the proc needs to return something) let me know or pr it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants