Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Pubby, stores the Pubby monastery as a space ruin. #9301

Merged
merged 4 commits into from
Aug 22, 2020

Conversation

smorgli
Copy link
Contributor

@smorgli smorgli commented Jul 23, 2020

Intent of your Pull Request

This is a result of the recent quickfire vote that is supposed to be a suggestion to maintainers.
Pubby is a bad station, not being maintained for the most part, it rarely ever gets picked, I don't want to work on it, at least 90 people don't like it either:
Discord_LJI8UujEAD

The only good part about it was the monastery which for some reason came with a station attached to it.
chrome_is4MILv9If

What this PR does:
Removes pubby
Removes pubby arrivals shuttle,
Removes all the pubby specific objects like the nanomed and booze fridges

What this PR does not do:
Remove the monastery, it's going to be stored as an unspawnable space ruin and probably worked on later so it can appear
Remove the pubby escape shuttle

Changelog

🆑
rscadd: Adds the Pubbystation monastery as a space ruin
rscdel: Removes Pubbystation
/:cl:

@smorgli smorgli requested a review from Ktlwjec1 as a code owner July 23, 2020 12:35
@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this labels Jul 23, 2020
@smorgli smorgli added Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Controversial People are divided on this PR labels Jul 23, 2020
@github-actions github-actions bot added the Config Config files need to be changed on the host for this to work label Jul 23, 2020
@Partheo
Copy link
Contributor

Partheo commented Jul 23, 2020

Actually good PR. Removes something that was weighing down the codebase, but keeps the distilled spirit.

@swissloaf
Copy link
Contributor

yeah pubby is kinda bad ngl

@ghost
Copy link

ghost commented Jul 23, 2020

BUT MUH REMOVE DONT IMPROVE

There's so much broken shit in this station that it'll be a nightmare to fix, and even then it's not going to be worth it.

@MegaEmpirical
Copy link

I really liked Pubby, damned savages. Good night sweet prince.

@boodaliboo
Copy link
Contributor

i love pubby ill miss it

@alexkar598
Copy link
Member

alexkar598 commented Jul 24, 2020

Pubby is the one that's actually playable. Omega is the super broken one.

It does a good job at being a low pop map and other than omega we dont have any low pop map but omega is super broken and hasn't been maintainer in over a year

@smorgli
Copy link
Contributor Author

smorgli commented Jul 24, 2020

Pubby is the one that's actually playable. Omega is the super broken one.

It does a good job at being a low pop map and other than omega we dont have any low pop map but omega is super broken and hasn't been maintainer in over a year

wut, you can literally go on https://github.com/yogstation13/Yogstation/pulls?q=is%3Apr+omega
And see how many Pr's there were for it in vs for pubby : https://github.com/yogstation13/Yogstation/pulls?q=is%3Apr+pubby
Of course there are some unrelated ones but this is just a rough estimate. Even though Pubby gets more results, they are more spread throughout the timeframe. Omega has had more

@alexkar598
Copy link
Member

Difference is that pubby was still maintained when we debased, omega was not. Omega has been relativly unmaintained for longer than pubby

@alexkar598 alexkar598 added the Awaiting - Vote - Poll This PR is awaiting the completion of a server poll label Jul 25, 2020
@JamieD1
Copy link
Contributor

JamieD1 commented Aug 15, 2020

Marked for deletion, bloody cornflakes

@smorgli smorgli requested a review from a team as a code owner August 17, 2020 20:58
@smorgli smorgli requested a review from a team August 17, 2020 20:58
@smorgli smorgli requested a review from a team as a code owner August 17, 2020 20:58
@smorgli smorgli requested a review from JamieD1 August 17, 2020 21:13
@alexkar598
Copy link
Member

This is stupid but whatever

@alexkar598 alexkar598 merged commit d0ab06a into yogstation13:master Aug 22, 2020
Yogbot-13 added a commit that referenced this pull request Aug 22, 2020
@smorgli smorgli deleted the removespubby branch March 16, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Awaiting - Vote - Poll This PR is awaiting the completion of a server poll Config Config files need to be changed on the host for this to work Controversial People are divided on this PR Feature This adds new content to the game Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants