Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional department goals #9457

Merged
merged 5 commits into from
Aug 15, 2020
Merged

Conversation

Amelia0010
Copy link
Contributor

@Amelia0010 Amelia0010 commented Aug 13, 2020

Adds conditional department goals, IE goals that will only be added if certain conditions are true. Two examples added here are based on engineering:

If the station has a supermatter engine, the objective will be to setup a singularity. If the station has a singularity/tesla, the objective will be to setup a supermatter.

Also adds a goal for cargo to make a tesla engine in the cargo bay. Because you know, cargo ain't gonna have other goals.

🆑
rscadd: Engineering will now get a goal to set up the opposite engine of what they spawn with.
/:cl:

@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Aug 13, 2020
@Hopekz
Copy link
Contributor

Hopekz commented Aug 13, 2020

I like the idea of this PR and the framework of what it allows for the future.

The example you implemented with it of giving cargo an excuse to be engineering isn't too great in my opinion.
Hopefully, people won't take this framework to just make Cargo be every department ("Create a full RnD lab", "make an armory", "create a full medbay setup + cloning")

+1 good framework
-1 odd implementation to normalize cargo powergaming
= True neutral.

@Tipy1802
Copy link

Please for the love of god do not justify cargo powergaming. Cargo technicians are not supposed to know how to set up engines, maybe move it to engineering

@Amelia0010
Copy link
Contributor Author

OK hugboxer

@JamieD1
Copy link
Contributor

JamieD1 commented Aug 15, 2020

This has been a hot topic with admins, most admins want engineering to be part of this and not just let cargo powergame. Will come back to this.

@Amelia0010 Amelia0010 mentioned this pull request Aug 15, 2020
@Amelia0010
Copy link
Contributor Author

The cargo tesla goal has been split off into #9469 to avoid dragging this PR down with it.

@JamieD1 JamieD1 merged commit e7c79c5 into yogstation13:master Aug 15, 2020
Yogbot-13 added a commit that referenced this pull request Aug 15, 2020
@Amelia0010 Amelia0010 deleted the conditional-goals branch August 15, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This adds new content to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants