Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yogsmeta escape has proper airlocks #9467

Merged
merged 7 commits into from
Aug 19, 2020
Merged

Yogsmeta escape has proper airlocks #9467

merged 7 commits into from
Aug 19, 2020

Conversation

redmoogle
Copy link
Contributor

@redmoogle redmoogle commented Aug 15, 2020

Intent of your Pull Request

Yogsmeta has fucky airlocks where if 2 people try to go out the airlock at once all of escape is depressurized, this aims to fix that

Also The decal has been changed from stripes/boxes encompassing the whole room to just by the airlocks

Also fixed the shocked windows in the checkpoint

OLD

image

NEW

image

Changelog

馃啈
rscadd: Yogsmeta has proper escape airlocks
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Mapping Will result in a change to a map. labels Aug 15, 2020
@redmoogle
Copy link
Contributor Author

trying to debug some funkyness in this, they dont act like how yogstation does

@JamieD1 JamieD1 requested a review from smorgli August 15, 2020 13:36
@smorgli
Copy link
Contributor

smorgli commented Aug 15, 2020

What's up with the decals?

@redmoogle
Copy link
Contributor Author

If you mean why I changed them, it just looked strange like one giant box so I tried to tune it to be somewhat similar to yogstation escape decals

@smorgli
Copy link
Contributor

smorgli commented Aug 16, 2020

Idk i don't like it it looks barebones now, maybe add some corner decals instead if you want change?

@redmoogle
Copy link
Contributor Author

yeah Ill take another comb for decorations but i didnt find anything that suited escape

@redmoogle
Copy link
Contributor Author

Imma be really sad if mapdiffs is displaying this correctly

@alexkar598 alexkar598 added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label Aug 16, 2020
@redmoogle redmoogle requested a review from a team as a code owner August 17, 2020 10:50
@redmoogle
Copy link
Contributor Author

Idk i don't like it it looks barebones now, maybe add some corner decals instead if you want change?

Take a look at this new iteration of decorations

also w h a t did yogstation13/map just get ownership or something

Copy link
Contributor

@smorgli smorgli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes now it's better

@smorgli smorgli merged commit 49b129a into yogstation13:master Aug 19, 2020
Yogbot-13 added a commit that referenced this pull request Aug 19, 2020
@redmoogle redmoogle deleted the fdmm-patch-20563574-redmoogle branch August 25, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Feature This adds new content to the game Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants