Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete boxstation medbay map rework #9509

Merged
merged 13 commits into from Sep 11, 2020
Merged

Conversation

smorgli
Copy link
Contributor

@smorgli smorgli commented Aug 19, 2020

Intent of your Pull Request

Box medbay sucks, it has two power areas that are all messed up together, and the treatment center is smaller then captains johnson. I wanted to change just the areas and add more apc's but it sort of escalated from there and I did a full rework.

Overview

Let's begin with the general power area overview:
UAj8fyPJ3h
Each color has a separate apc that is in medbay itself, not lost somewhere in maint.

Entire thing without areas:
chrome_t7G41PVnVT

Room by room

EMT office:
dreamseeker_laylQ1ubEX
Medic space suit inside the storage unit.

Break/dressing room:
dreamseeker_5bEMJHYgmS

Storage:
dreamseeker_khJGcWmO7J

Probably the best thing about this, the treatment room:
dreamseeker_XqAv87naXf

Now with a lot more space for expansion projects.

To the right of it is surgery:
dreamseeker_gqaKAcf2lc

Genetics/Cloning:
dreamseeker_oUpijrnUis
Now with spare scanners, cable coil and morphine in the locker

Sec checkpoint/west part:
dreamseeker_qEpg8VPKiR

Chem:
dreamseeker_yiDcVZ7c5Z

The beautiful lobby:
dreamseeker_NCvcUAiW2g

Cmo office/Corridor:
dreamseeker_g6hJPgCtRO

Psych:
dreamseeker_ZhkxhEKlCc

Patient recovery/aft hallway
dreamseeker_FLGNgHppx1

Yeah that's pretty much it. I didn't touch viro and probably am going to add surgery variations in the future. Constructive criticism welcome.

Changelog

🆑
tweak: complete boxstation map medbay rework
/:cl:

MAINTAINER EDIT: Wrapped the images in a collapsible thing

@smorgli smorgli requested a review from a team as a code owner August 19, 2020 11:53
@Yogbot-13 Yogbot-13 added Mapping Will result in a change to a map. Tweak This PR contains changes to the game. labels Aug 19, 2020
@Partheo
Copy link
Contributor

Partheo commented Aug 19, 2020

Big fan! My feedback:

I think there should be a second door somewhere on this wall, since the treatment room is a common destination.
image

Especially so considering people will have to exit like this:
image

If you fix that, I feel like you then will have much less straight traffic through this hallway, and can afford to put more interesting objects in it, like the two beds you already have there.
image

Some chairs or tables would be nice- hallways are often a rest/chill spot for doctors and nurses (and even patients) IRL.
image

In general, I dislike this design of lobby; it feels kind of generic like the sort you see in bay-paradise-furry-etc servers. If you commit to the one-way circular design though, I think it'd be fine, but the current symmetry is boring.
image

@Partheo
Copy link
Contributor

Partheo commented Aug 19, 2020

Also this maint is boring:
image

@Tipy1802
Copy link

Honestly this is AMAZING, I absolutely adore it, my favourite part is the reception.

I have some critiques which I posted in the discord since I can’t post pics in here from a phone

@Mesalikepie
Copy link

Love the rework! Looks amazing only concern I can even think of that wasn't already mentioned is the hypospray is going to be so much harder to steal, but it's still looking doable. Love the new map!

@smorgli
Copy link
Contributor Author

smorgli commented Aug 19, 2020

Updating based on suggestions from discord and here.
Lobby doors have separate buttons now, psych gets a muzzle and straightjacket, surgery gets shutters instead of blast doors, sec gets a camera monitor, cmo walls are not reinforced, some missing decals, a way to get out of the treatment center, chairs, plants, sinks.

chrome_IGwTnkF8AL

chrome_t7G41PVnVT

dreamseeker_XqAv87naXf

@Moggram
Copy link

Moggram commented Aug 19, 2020

God dam, that's a sexy medbay.

@smorgli smorgli added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label Aug 19, 2020
@alexkar598
Copy link
Member

Cloning is miles away from the morgue, way too many doors, an emp would cripple medbay instantly and just the general chaos would turn every single door into a choke point

@alexkar598
Copy link
Member

Surgery having no maint access is a huge nerf to stealthy antag actions

@Partheo
Copy link
Contributor

Partheo commented Aug 19, 2020

Cloning is miles away from the morgue

It's a straight hallway to the morgue, and in a low-traffic part of it too. I really think you are exaggerating the problem.

way too many doors, an emp would cripple medbay instantly and just the general chaos would turn every single door into a choke point

This is a pretty good point, I think there are quite a few door candidates you could replace with simple passages in this design. That being said, I don't think EMP crippling medbay is a bad thing. That's kind of the point of an EMP.

@smorgli
Copy link
Contributor Author

smorgli commented Aug 19, 2020

Cloning is miles away from the morgue, way too many doors, an emp would cripple medbay instantly and just the general chaos would turn every single door into a choke point

Cloning is in the back to encourage other approaches to healing, emp's point is to cripple as Parth said. I could remove this door
chrome_SBcOjSbsLQ
but my intention is to close medbay off so it's an actual department, not a public zone

Surgery having no maint access is a huge nerf to stealthy antag actions

Yes, i moved surgery out of the back to encourage it, same point as with cloning.
All this being said is, it's hard to balance all of it perfectly, i tried my best and i think it turned out ok, guess we'll see how it goes.

@Hopekz
Copy link
Contributor

Hopekz commented Aug 19, 2020

Literally being changed for the sake of being changed like the weird tcomms and AI swap that no-one seemed to ask for.

@ToGWtF
Copy link
Contributor

ToGWtF commented Aug 19, 2020

I dont like that medical storage is so much harder to get to

@smorgli
Copy link
Contributor Author

smorgli commented Aug 19, 2020

Literally being changed for the sake of being changed like the weird tcomms and AI swap that no-one seemed to ask for.

The change is based on the complaints that

  1. Medbay should not be a public department
  2. The treatment centre is too small and cramped
    Parth explains it in #mapping further

I dont like that medical storage is so much harder to get to

It's medical storage, not public medicine storage

@maxion12345
Copy link
Contributor

Swap sleeper and stasis so there's a spot to wall-mount defibs next to a stasis bed.

@smorgli
Copy link
Contributor Author

smorgli commented Aug 20, 2020

Swap sleeper and stasis so there's a spot to wall-mount defibs next to a stasis bed.

Good point, moved some things around to make both beds have a wall next to them

chrome_sn1r9Ey4Z1

@boodaliboo
Copy link
Contributor

my only problem is medical should be in general public im fine with every department in their isnt but medical itself should be

@Tipy1802
Copy link

my only problem is medical should be in general public im fine with every department in their isnt but medical itself should be

Having people treat medbay as a public hangout spot has to be by far the worst part of being a medical doctor. Having to babysit a kindergarten trying to break into medical storage while you are saving the dying captain while people push you causing to fail and Assitant McTide yelling at you non stop to heal his 5 burn damage and then get called shit in ooc just isn’t fun and one of the main reason people don’t play MD

@MonsWTF
Copy link
Contributor

MonsWTF commented Aug 20, 2020

my only problem is medical should be in general public im fine with every department in their isnt but medical itself should be

Imagine IRL hospitals just letting anyone wander inside the building.

Also, are we just going to ignore how massive that lobby area is, that's already available to the general public??

image

@smorgli
Copy link
Contributor Author

smorgli commented Aug 20, 2020

Will fix conflicts after review is complete.

@Reed0506
Copy link

this is generally cool and good from my glances at the pictures

@MegaEmpirical
Copy link

MegaEmpirical commented Aug 22, 2020

Hey! Give medics their firesuit locker back whilst you're at it!!!!!

Also, I love this, well done.

@MonsWTF
Copy link
Contributor

MonsWTF commented Aug 22, 2020

After giving it another look-over, I think the only remaining adjustments I would personally want to see on my end is the outer tiles being converted back to regular grey (you can leave the blue outline, though).

image

It should only be white half-way thru that walk-in point, so that the medbay theme isn't bleeding into the main hallway too much.

@smorgli
Copy link
Contributor Author

smorgli commented Aug 22, 2020

After giving it another look-over, I think the only remaining adjustments I would personally want to see on my end is the outer tiles being converted back to regular grey (you can leave the blue outline, though).

I actually did change something about the entrance but didnt update the picture, here is what it looks now:
Screenshot_20200822-221011_Fennec_F-Droid_1.png

Will take another look later with your suggestion in mind.

@MonsWTF
Copy link
Contributor

MonsWTF commented Aug 22, 2020

Ahh, interesting. Yeah, my issue with it being out in the hallway is that it's jutting out and adding color, whereas further down the hall, the Kitchen area has the same pattern, but it's receding inward to draw people in.

@Partheo
Copy link
Contributor

Partheo commented Aug 22, 2020

Agreed with Mons- I like the blue decal you have going around the window, and I think blue tiles outside would be fine (somewhat like the bridge) but the white tiles are distracting and should remain in the department IMO.

@smorgli
Copy link
Contributor Author

smorgli commented Aug 24, 2020

Firefighter locker added to emt office, Lobby entry is more subtle now:
chrome_TwKUbV2vrl

@MegaEmpirical
Copy link

Glorious rise to medics!

@Firewolf34
Copy link
Contributor

This is so sorely needed. Please let this one get merged...

Most important additions I think are keeping the damn tide out of the medbay proper, having people actually use reception, and the double surgery. 2 surgeries is sooooo incredibly important, not only because it's always crowded as hell, but also because we are trying to push towards making surgery more relevant and medbay less of a instant sleeper/clone-fest.

Love this. Nice touch on CMO being out front and not locked weirdly away in a corner like an afterthought.

@Moja10
Copy link
Contributor

Moja10 commented Sep 6, 2020

I support this being merged. It's about time a radical change like this was introduced, I think the AI telecoms swap went over well. I am a big fan of the new storage, looks much better overall.

@alao3alao3
Copy link
Contributor

Way too many vents and scrubbers. I don't think we should use that trimline decals either, since no other departments have them and it kinda makes. Would've been nice if we really dialed it back with the window we could probably put the APCs back in maint like every other department. Whole medbay feels overcrowded, and it looks like it was built for a completely different station.

@MegaEmpirical
Copy link

These are the right amount of vents and scrubbers for rooms of these sizes.

@alao3alao3
Copy link
Contributor

There’s 2 pairs of vents and scrubbers in the main treatment room, and there’s 4 pairs for that one hallway. Even cargo bay doesn’t have that many. I’m not a big fan of that shrunken storage room either.

@MegaEmpirical
Copy link

Like I said, an appropriate amount. Cargo bay should have two sets and is under served, this is because when Nich re-did the pipe layers he destroyed a lot of the pipe system instead of preserving how it was.

See engineering hallway, I has one vent and scrubber, each at opposite ends. The firelocks even block them from entire chunks of one long hall.

@alao3alao3
Copy link
Contributor

If you say so, I still think it sticks out like a sore thumb, if not because of the excessive vents and scrubbers then because of the use of decals not used anywhere and all of those goddamn windows.

Why was the pipe system in medbay redone? I didn’t notice it until now, but it enters and exits in like 4 different ways. Surely it wasn’t like this before and could’ve been kept that way, no?

@MegaEmpirical
Copy link

So it was actually normal for pipes to enter into departments from multiple entrances, this is less so now due to that rework. I fought to try to maintain as much as that redundancy as possible as it severely hurts the piping system without.

As for why, Nich wanted to make the piping less chaotic and easier to follow by making use of the pipe layers so he had distro on layer 1 and waste on 3 and didn't want anything coming though the walls so like 95% of pipes come in by way of door/plastic flaps. And because they are on the same layer you can lay them together instead of having to avoid eachother, which was originally a confusing web of pipes.

@alao3alao3
Copy link
Contributor

Hell I’m tempted to say you made the PR at this point. Do you have Nich’s reasoning on why there are so many windows, and why all of the APCs (instead of just cloning/genetics) are in the department instead of in maint?

@smorgli smorgli deleted the med branch March 16, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Mapping Will result in a change to a map. Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet