DREAM REWORK #2392
DREAM REWORK #2392
Conversation
|
Speed merge |
|
This isn't WIP. I will add all the other stuff in seperate PRs |
|
merge? |
This reverts commit 24c07fd.
I didnt test this, but how could this possibly go wrong?
| @@ -45,7 +45,8 @@ | |||
| M.confused += power | |||
| if(ishuman(M) && ishuman(user) && M.stat != DEAD) | |||
| if(user.mind && (user.mind in ticker.mode.head_revolutionaries)) | |||
| if(M.client) | |||
| if(M.isActive()) | |||
| world << "11" | |||
| var/name = "Dream Controller" | ||
| var/dreaming = FALSE | ||
| var/mob/living/carbon/owner | ||
| var/mob/living/carbon/human/dream/DB = /mob/living/carbon/human/dream |
There was a problem hiding this comment.
I'm pretty sure you need to create an instance via new(), otherwise, this is just a typepath and not something that has any vars.
There was a problem hiding this comment.
That's done on line 30
There was a problem hiding this comment.
You try to access the variables of DB on line 12, where it still doesn't exist (as /Dream starts first, then it calls /startDream, if I understand the code correctly, meaning you are still trying to access the variables before you ever first create the instance).
Is startDream (the place the DB instance is created) called somewhere outside Dream when you initialize the world or something?
There was a problem hiding this comment.
Start dream is called at line 23
Also about the DB, yes its to make sure things dont get buggy, hence there's the ishuman check to make sure it's actually has variables and I can acces it
The reason I dont put it directly in new is because I don't need to create the mobs for every single human, just for those that fall asleep, it'd be a waste to create them even for someone that will never use it
There was a problem hiding this comment.
nvm i couldve just straight up called new() and it would've used the path of the actual var, sorry i understand now
|
Please merge |
|
Oi morgue this PR |
|
This didn't occur to me. |
|
Do you have any more info about how it happened? If it happened then it'll happen again on live sooner or later. |
|
please merge this quickly, dreaming is so fucking lame right now |
|
I cannot actually reproduce it anymore either. I have no idea how it happened to me twice in a row. |
|
A lot of people are saying that their dream bodies are always female |
|
Never happened to me, that's good enough to be brushed off as an accidental feature |
Clicking a dream person teleports you to their real body. Using the orbit menu, does not. Also fixes the survival rate
|
Latest commits: |
|
Is there a way to put the dream bodies at the bottom of the list? It's kinda annoying having to go through all of the Dream people looking for someone named "driscoll hooker" for example |
|
I increased heavily on the stability and did some other misc stuff since the original testmerge
|
| for(var/mob/living/carbon/human/dream/D in mob_list) | ||
| D.dream.setInvisibility() //If one new dude comes in, he will be visible, so redo the invisibility for all... | ||
| key = "@[C.ckey]" | ||
| world << "1 [key]" |
|
can we like, not move ckeys off of mobs and instead just use cameras and replace the sprite to a copy of the mobs sprite? it prevents the inevitable 5000 edge cases from this PR . You don't need a real mob in dreamland anyways. this is honestly way too messy for a feature like crit dreams and brings more issues than it should. 2 snowflake 5 me. |
|
There are a ton of runtimes at roundstart, and MMIs placed into borg exoskeletons do not transfer the mind of the brain into the cyborg. |
|
Re-add deathwhisper. If you are in deep crit you should be able to immediately die whenever you want to. Or just remove dream word from crit entirely. It’s a major inconvenience. |
|
Its ok. I've been discouraged so bad, I give up. Just revert the ugly dreaming we have right now and life with the old shit. |
|
Damn. My dreams of living old CRP are dead. |
|
why did i get a ping from this |
|
|
Dreaming
Now it actually lets you walk around in a dream world and do fuck all.
There will be alot of bugs, so make sure to report them
Picture of small piece of one of the two areas: https://i.gyazo.com/a8015a0a498038e08b1ae47938cfb907.png
🆑
experimental: Reworks dreaming. Thanks to kayozz for sounds and kmc for making a dream area
/:cl:
Mappers please map. I am horrible at it.
I will add this in future PRs:
Antag dreams (meetings?)
Nightmares
Holding onto life
(maybe more)
Mappers, feel free to add areas for nightmares or other not yet made code. It'll be unused but I'll use it later then.
Also I am gonna keep alot of stuff about this PR secret, so not too many pictures. Mystery is the fun part about features. Ask me directly for real info
I should mention to all coders. The isActive() proc checks if the person is still there, dreaming or not, and then pulls them back so you can use their mind. isActive(1) only checks for them and doesnt pull them back