Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Handle language-out option #18

Merged
merged 5 commits into from
Oct 17, 2018

Conversation

rangeoshun
Copy link
Contributor

@rangeoshun rangeoshun commented Oct 17, 2018

Fixes #17
Allows for setting of language-out option.

Concats externs with default externs for ES6 support.

BREAKING language renamed to language-in for sake of descriptiveness.

If you think, I'm also OK with leaving it as-is for the sake of backwards compatibility.

@rangeoshun rangeoshun changed the title BREAKING: Handle language out options #17 BREAKING: Handle language-out option Oct 17, 2018
@yogthos
Copy link
Owner

yogthos commented Oct 17, 2018

Looks good to me, would you mind updating the docs as well to reflect the new language keys.

@rangeoshun
Copy link
Contributor Author

Updated the default input to ecmascript6, as that should be totally backwards compatible, and should be the expected behaviour in general. Objections?

@rangeoshun
Copy link
Contributor Author

README updated.

@yogthos yogthos merged commit e943917 into yogthos:master Oct 17, 2018
@yogthos
Copy link
Owner

yogthos commented Oct 17, 2018

Fantastic, I just pushed out v 0.2.6 to Clojars with the changes. Thanks for the pr. :)

@rangeoshun
Copy link
Contributor Author

Many thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants