Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List migration logs #251

Merged
merged 23 commits into from
Aug 30, 2023
Merged

List migration logs #251

merged 23 commits into from
Aug 30, 2023

Conversation

sandre1
Copy link
Contributor

@sandre1 sandre1 commented Aug 22, 2023

  • logs for list available (all), pending, applied migrations with applied-date visible
  • option --format FILE-FORMAT in CLI to list migrations (as logs) in .edn and .json format

@yogthos
Copy link
Owner

yogthos commented Aug 22, 2023

Overall looks good to me, would just swap out cheshire for clojure.data.json

src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/cli.clj Outdated Show resolved Hide resolved
src/migratus/core.clj Outdated Show resolved Hide resolved
@sandre1 sandre1 marked this pull request as ready for review August 28, 2023 10:50
@yogthos
Copy link
Owner

yogthos commented Aug 28, 2023

@ieugen thanks for doing a more thorough review, and I'm good to merge if everything looks good to you

src/migratus/cli.clj Outdated Show resolved Hide resolved
@ieugen
Copy link
Collaborator

ieugen commented Aug 30, 2023

@yogthos : I think it's ready to merge.
I am not particularly fond of terminal output with logging.
It would be nice to improve that, but I think the code is an improvement to migratus and a step forward.

@ieugen ieugen merged commit cedf10e into yogthos:master Aug 30, 2023
@sandre1 sandre1 deleted the list-migration-logs branch August 30, 2023 08:33
@yogthos
Copy link
Owner

yogthos commented Aug 30, 2023

Agreed, we could do a separate PR to make that nicer. And just released 1.5.3 to Clojars with the update @sandre1 thanks for spearheading the effort on this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants