ArrayLoader should respect state accessor #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realshadow
changed the title
|
Interesting, could you add a test for this ? |
added test for array loader with custom state accessor
|
Hey, I have added one test and squashed the commits. Is that ok or did you have something else in mind? |
|
@realshadow 👍 thank you ! |
flobb
pushed a commit
to flobb/Finite
that referenced
this pull request
Sep 22, 2016
ArrayLoader should respect state accessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
ArrayLoadercurrently always overwrites state accessor during loading of state machine, this PR attempts to fix that