Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

found "extend" but expected [;] #27

Closed
aLekSer opened this issue Jun 12, 2019 · 5 comments
Closed

found "extend" but expected [;] #27

aLekSer opened this issue Jun 12, 2019 · 5 comments

Comments

@aLekSer
Copy link

aLekSer commented Jun 12, 2019

Found this while running protolint on https://github.com/googleapis/googleapis/blob/master/google/api/annotations.proto

protolint -v ./annotations.proto results:

...
2019/06/12 14:13:29 [DEBUG] Text=[;], Token=[8], Pos=[proto/googleapis/google/api/annotations.proto:26:34] called from option.go:80                                                                      
2019/06/12 14:13:29 [DEBUG] Text=[extend], Token=[2], Pos=[proto/googleapis/google/api/annotations.proto:28:1] called from lexer.go:127                                                                  
2019/06/12 14:13:29 [DEBUG] Text=[extend], Token=[2], Pos=[proto/googleapis/google/api/annotations.proto:28:1] called from lexer.go:127                                                                  
2019/06/12 14:13:29 [DEBUG] Text=[extend], Token=[2], Pos=[proto/googleapis/google/api/annotations.proto:28:1] called from parser.go:44                                                                  
2019/06/12 14:13:29 [DEBUG] Text=[extend], Token=[2], Pos=[proto/googleapis/google/api/annotations.proto:28:1] called from lexer.go:127                                                                  
2019/06/12 14:13:29 [DEBUG] Text=[extend], Token=[2], Pos=[proto/googleapis/google/api/annotations.proto:28:1] called from emptyStatement.go:10                                                          
found "extend" but expected [;] at /Users/alexander/go/src/github.com/yoheimuta/go-protoparser/internal/lexer/emptyStatement.go:16  

I think extend keyword is missing but could not find it in proto styleguide.

@yoheimuta
Copy link
Owner

@aLekSer Thank you for reporting!
I will handle this issue to prevent errors.

@yoheimuta
Copy link
Owner

I will first fix yoheimuta/go-protoparser#24.

@yoheimuta
Copy link
Owner

@aLekSer #28 fixed this issue. Could you confirm it?

@aLekSer
Copy link
Author

aLekSer commented Jun 12, 2019

Thank you, now this issue is fixed also.

@yoheimuta
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants