Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INDENT rule doesn't handle "extend" properly #63

Closed
pascalmr opened this issue Aug 19, 2019 · 3 comments
Closed

INDENT rule doesn't handle "extend" properly #63

pascalmr opened this issue Aug 19, 2019 · 3 comments
Assignees
@yoheimuta
Labels
bug Something isn't working

Comments

@pascalmr
Copy link

pascalmr commented Aug 19, 2019 •
edited

Issue #27 introduced support for the "extend" keyword.
Unfortunately the indent rule doesn't handle it correctly. It seems to expect no indentation for the extension content (https://github.com/googleapis/googleapis/blob/master/google/api/annotations.proto):
[google\api\annotations.proto:30:3] Found an incorrect indentation style " ". "" is correct.
[google\api\annotations.proto:29:3] Found an incorrect indentation style " ". "" is correct.
@yoheimuta
Copy link
Owner

@pascalmr Thank you for your report.
It appears to be sure in need of the fix.

@yoheimuta yoheimuta added the bug Something isn't working label Aug 20, 2019
@yoheimuta yoheimuta self-assigned this Aug 21, 2019
@yoheimuta yoheimuta mentioned this issue Aug 21, 2019
Merged
@yoheimuta
Copy link
Owner

I fixed it by #68.

@yoheimuta
Copy link
Owner

@pascalmr Please let me know if you can still experience the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoheimuta yoheimuta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yoheimuta @pascalmr