Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -no-error-on-unmatched-pattern option to lint #134

Merged
merged 1 commit into from
Jul 25, 2020
Merged

add -no-error-on-unmatched-pattern option to lint #134

merged 1 commit into from
Jul 25, 2020

Conversation

jd1378
Copy link
Contributor

@jd1378 jd1378 commented Jul 25, 2020

fixes #133

yoheimuta
yoheimuta approved these changes Jul 25, 2020
View reviewed changes
Copy link
Owner

@yoheimuta yoheimuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@yoheimuta
Copy link
Owner

It worked well.

❯❯❯ ./protolint _doc; echo "\n$?"
not found protocol buffer files in [_doc]
2
❯❯❯ ./protolint -no-error-on-unmatched-pattern _doc; echo "\n$?"
not found protocol buffer files in [_doc]
0

@yoheimuta yoheimuta merged commit 4a1b88f into yoheimuta:master Jul 25, 2020
@yoheimuta yoheimuta mentioned this pull request Jul 25, 2020
Closed
@jd1378 jd1378 deleted the add-no-error-on-unmatched-pattern-flag branch July 25, 2020 12:19
Tarsmash
Tarsmash reviewed Oct 15, 2020
View reviewed changes
Copy link

@Tarsmash Tarsmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protolint lint -no-error-on-unmatched-pattern . # exits with success code even if no file is found (file & directory mode)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarsmash Tarsmash Tarsmash left review comments

@yoheimuta yoheimuta yoheimuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return with exit code 0 if no files are found
3 participants
@jd1378 @yoheimuta @Tarsmash