Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.download.useDownloadDir #267

Closed
hub2git opened this issue Dec 15, 2023 · 1 comment · Fixed by #268
Closed

browser.download.useDownloadDir #267

hub2git opened this issue Dec 15, 2023 · 1 comment · Fixed by #268

Comments

@hub2git
Copy link

hub2git commented Dec 15, 2023

Dear dev yokoffing,
I am using your betterfox creation. Thank you for your work on that . My fave browser is now more secure.

In the Peskyfox section there is this line:

user_pref("browser.download.useDownloadDir", false);

Why? Isn't being asked always where to save the pesky choice? In other words, isn't it less pesky for the line above to say "true"?

The description of Peskyfox (in https://github.com/yokoffing/BetterFox#simple-configs) says: "Provide a clean, distraction-free browsing experience."

Isn't being always asked where to save a download distraction-full?

My entire user.js is at https://gist.github.com/hub2git/0076fa1464e9c3ffd73839a6e6b2182d

@yokoffing yokoffing changed the title Peskyfox has user_pref("browser.download.useDownloadDir", false). But isn't the opposite the distraction-fee choice? browser.download.useDownloadDi Dec 15, 2023
yokoffing added a commit that referenced this issue Dec 20, 2023
@yokoffing yokoffing changed the title browser.download.useDownloadDi browser.download.useDownloadDir Dec 20, 2023
@yokoffing
Copy link
Owner

yokoffing commented Dec 20, 2023

You're not wrong. The pref browser.download.useDownloadDir was added for security, but I'm happy to revisit it.

Betterfox/Peskyfox.js

Lines 322 to 339 in f269678

// PREF: always ask where to download
// Enforce user interaction for greater security.
// [SETTING] General>Files and Applications>Downloads>Always ask you where to save files
// [DIALOGUE] "Ask whether to open or save files"
// true=direct download (default)
// false=the user is asked what to do
// [1] https://github.com/yokoffing/Betterfox/issues/267
user_pref("browser.download.useDownloadDir", false);
//user_pref("browser.download.dir", "C:\Users\<YOUR_USERNAME>\AppData\Local\Temp"); // [WINDOWS]
// PREF: always ask how to handle new mimetypes
// Enforce user interaction for greater security.
// [SETTING] General>Files and Applications>Applications>What should Firefox do with other files?
// false=Save files
// true=Ask whether to open or save files
user_pref("browser.download.always_ask_before_handling_new_types", true);

We currently have settings that prioritizes security and users who prefer to download in various locations.

A build that balances annoyances and security may be:

user_pref("browser.download.useDownloadDir", true); // DEFAULT
user_pref("browser.download.always_ask_before_handling_new_types", true);

This way Firefox saves common files without unneeded interaction (Content Type), but alerts the user for first-time file types or unlisted types (What should Firefox do with other files?).

Screenshot 2023-12-20 091431

@yokoffing yokoffing linked a pull request Dec 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants