requests > 2.4.2 has an optional .post json arg #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoidyzoidzoid
force-pushed
the
requests-2-support
branch
from
b5e8431
to
975e6bb
Compare
|
👍 Seems reasonable. But consumer requirements will probably need updating, too. |
|
Minor version bump with a warning or a major version bump in case people are fiddling with |
|
Minor is fine. |
|
👍 |
zoidyzoidzoid
added a commit
that referenced
this pull request
Apr 1, 2015
requests > 2.4.2 has an optional .post json arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests changelog
There haven't been any huge API changes since version one of requests. We could probably support
>=1.0.0, <3.0.0.