Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.1.5 for working release #46

Closed
wants to merge 1 commit into from
Closed

Bump to 1.1.5 for working release #46

wants to merge 1 commit into from

Conversation

alexmojaki
Copy link
Contributor

See changelog.

@beck
Copy link
Contributor

beck commented Nov 23, 2015

I'm being nit-picky... but I would like to see this broken into two commits:

1 - the version bump
2 - the change log

That way the version bump commit can be tagged appropriately as the version that was published

@stefanor
Copy link

@beck: I don't see why the version-bump commit would be the one that is tagged. There's nothing wrong with bumping the version miles before the tag.

Practically, it'll probably be the merge commit from this PR that gets the tag.

@beck
Copy link
Contributor

beck commented Nov 23, 2015

There's nothing wrong with bumping the version miles before the tag.

Very true (and is normally the case) but v1.1.5 has already been published

@stefanor
Copy link

What matters is that the tag matches the upload.

If that's true 👍

@beck
Copy link
Contributor

beck commented Nov 23, 2015

What matters is that the tag matches the upload.

It does not. That is why I made the comment.

The upload only has the version bump.

@alexmojaki
Copy link
Contributor Author

Opened #47 to replace this.

@alexmojaki alexmojaki closed this Nov 23, 2015
@alexmojaki alexmojaki deleted the bump-1.1.5 branch November 23, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants