New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin to run on 2019.2 - 2019.3 with Kotlin 1.3 #9
base: master
Are you sure you want to change the base?
Conversation
The gradle intellij plugin failed with an error, so I upgrade it. Since it required a higher minimum Gradle, I bumped Gradle to the latest version as well, as well as the Kotlin gradle plugin.
Fixes #7 |
It works more or less for 2019.2 thanks! "JITWatch Report" is empty. |
…on in version number
@yburkouski I updated the plugin to work with 2019.2, the JITWatch report panel works with both Kotlin Plugin 1.3.50 and 1.3.41 Check out https://github.com/alshain/jitwatch-intellij/releases/tag/v1.0.2 |
@alshain no, nothing changed :) and it looks like '.jar' doesn't have some needed classes, so my install path is to build intellij->buildPlugin target and then installing '.zip' file that is about 4.7Mb. Build log, I see some errors but BUILD SUCCESSFUL at the end. Using JDK 13, running test program under JDK 8
14:42:22: Executing task 'buildPlugin'...
BUILD SUCCESSFUL in 18s |
@yburkouski can you share a stack trace from within the Intellij logs? Also, maybe try installing the build I published here: I only tested from within |
@alshain do you have a build for 2020.2? |
I have updated the plugin to work with both IntelliJ 2019.2 and 2019.3 EAP and Kotlin plugin versions 1.3.41 and 1.3.50
I have updated the plugin to work with IntelliJ 2018.1, 2018.2, 2018.3 and 2019.1
The plugin didn't build for me after checkout due to some path handling issue in gradle-intellij-plugin, so I've updated it. This also required a Gradle update.
It's possible to compile the plugin against each version by changing the
platformVersion
property ingradle.properties
. I've adapted the approach the Rust plugin takes for that.The Kotlin support seems to be "working" for the simple test case I threw at it.
KotlinTypeMapper
takes different arguments now so I've taken a best guess as to what to pass for the parameters.