fix The given SOAPAction checkVat does not match an operation. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unknown reason this gem now throws this error: `The given SOAPAction checkVat does not match an operation.` The reason for this is that savon inserts a SOAPaction header that brokes it. This workaround removes that header and the error is no longer risen. I didn't find any other workaround to remove this error. For more info look here: Savon::SOAPRequest#configure_headers
|
Failed specs. Can you please run them again? |
|
I have no idea what truffleruby is and I didn't touch normalize function so probably sth else should be fixed also |
|
Ok, for now I'll fork your PR and use it on my project. |
|
Thanks @lubosch for the fix. I can confirm the error. Seems to be a change in the WDSL-file, which savon isn't handling correctly. The error in truffleruby seems to be completly unrelated. |
klouvas
added a commit
to Workable/valvat
that referenced
this pull request
Oct 29, 2021
|
Will you send a new release? |
|
Yes. Give me some minutes. |
|
Just released v1.1.2 including the fix. |
|
@yolk any chance for 1.0.2 version with this fix for legacy systems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason this gem now throws this error:
The given SOAPAction checkVat does not match an operation.The reason for this is that savon inserts a SOAPaction header that brokes it. This workaround removes that header and the error is no longer risen. I didn't find any other workaround to remove this error. For more info look here:
Savon::SOAPRequest#configure_headers