This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Node view #21
Merged
Node view #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nityanandagohain
commented
Sep 13, 2020
nityanandagohain
commented
yolossn
reviewed
Sep 13, 2020
pkg/gui/layout.go
Outdated
| @@ -42,7 +42,7 @@ func (gui *Gui) layout(g *gocui.Gui) error { | |||
| clusterInfoView.Highlight = true | |||
| } | |||
|
|
|||
| namespaceViewHeight := termHeight - unitHeight - 1 | |||
| namespaceViewHeight := termHeight - unitHeight - 7 | |||
There was a problem hiding this comment.
The height of namespaceView can be reduced and nodeView can be increased by 1 unitHeight
yolossn
reviewed
Sep 13, 2020
pkg/gui/node.go
Outdated
| return nil | ||
| } | ||
|
|
||
| if gui.getNSCount() == 0 { |
There was a problem hiding this comment.
Must be changed to NodeCount here
There was a problem hiding this comment.
why check Namespace count when rendering node ?
|
LGTM. Later we have to add handler functions for click on node. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.