This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Ensure that Dhcp_client.input does not raise an exception #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks `mirage -t macosx` since the Vmnet interface sprays all sorts of multicast packets which are not valid DHCP packets. A future improvement to this layer is probably to listen on the right DHCP ports, but this unbreaks OSX mirage for now.
4 tasks
|
IMHO we should do the opposite, and fix |
|
hannesm: yes agreed re: pkt_of_buf, although i think it should probably throw internally for the step-by-step parsing and then the outer interface should turn that into a Result (to avoid byte-by-byte parsing allocations) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks
mirage -t macosxsince the Vmnet interface spraysall sorts of multicast packets which are not valid DHCP packets.
A future improvement to this layer is probably to listen on the
right DHCP ports, but this unbreaks OSX mirage for now.