Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logger with tid & improve open tracing in metadata #651

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Oct 13, 2023

No description provided.

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
yomo 猬滐笍 Ignored (Inspect) Visit Preview Oct 20, 2023 3:48pm

@woorui woorui self-assigned this Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #651 (7f0b6ea) into master (d4c8685) will decrease coverage by 0.36%.
The diff coverage is 46.42%.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   60.28%   59.93%   -0.36%     
==========================================
  Files          36       36              
  Lines        2702     2673      -29     
==========================================
- Hits         1629     1602      -27     
- Misses        970      972       +2     
+ Partials      103       99       -4     
Files Coverage 螖
core/context.go 65.85% <100.00%> (+1.29%) 猬嗭笍
pkg/id/id.go 50.00% <100.00%> (酶)
source.go 87.27% <100.00%> (+6.78%) 猬嗭笍
core/server.go 69.86% <92.30%> (+3.86%) 猬嗭笍
sfn.go 48.41% <50.00%> (+0.53%) 猬嗭笍
core/metadata.go 44.11% <35.95%> (-46.80%) 猬囷笍

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@fanweixiao fanweixiao added the feat/log Feature: logging label Oct 20, 2023
@fanweixiao fanweixiao changed the title refactor: logger with tid & approve tracing in metadata refactor: logger with tid & improve open tracing in metadata Oct 20, 2023
Copy link
Member

@fanweixiao fanweixiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徎

@fanweixiao
Copy link
Member

@woorui I've merged #644, seems conflict with this PR

@woorui woorui merged commit 6071f7d into master Oct 20, 2023
5 of 7 checks passed
@woorui woorui deleted the feat/gid branch October 20, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/log Feature: logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants