-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: separate the logic of distributed tracing #736
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This is really great. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 59.46% 61.45% +1.99%
==========================================
Files 37 40 +3
Lines 2810 2937 +127
==========================================
+ Hits 1671 1805 +134
+ Misses 1034 1020 -14
- Partials 105 112 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Omit the
WithTracerProvider()
options as manual injection of the tracer provider in the code is unnecessary. The tracing functionality will be activated upon setting the 'OTEL_EXPORTER_OTLP_ENDPOINT' environment variable.Changes
Before:
After:
run:
TODO
update related docs.