-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split provider and register #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
- Coverage 59.20% 58.21% -1.00%
==========================================
Files 42 45 +3
Lines 3226 3379 +153
==========================================
+ Hits 1910 1967 +57
- Misses 1202 1298 +96
Partials 114 114 ☔ View full report in Codecov by Sentry. |
venjiang
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LLMProvider
into two interfaces, one for storing registered funcs and another for LLM requesting.Additionally, provide the
register.SetRegister()
method to allow modification of the default Register.md
attribute to theservice
and inject themd
using theExchangeMetadataFunc
method. The signature of theExchangeMetadataFunc
function is as follows:Declare the
HandleOverview
andHandleInvoke
methods and mount the service toreq.Context()
.fix
ConnMiddleware
function bug in theai.go
file.