Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl+c cannot exit client if the client is reconnecting #787

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Apr 8, 2024

No description provided.

@woorui woorui self-assigned this Apr 8, 2024
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
yomo ⬜️ Ignored (Inspect) Apr 8, 2024 6:12pm

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.03%. Comparing base (d8e9984) to head (d40c4ea).

Files Patch % Lines
core/client.go 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   71.14%   70.03%   -1.12%     
==========================================
  Files          49       49              
  Lines        2599     2606       +7     
==========================================
- Hits         1849     1825      -24     
- Misses        627      660      +33     
+ Partials      123      121       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woorui woorui merged commit 522c6a4 into master Apr 9, 2024
5 of 7 checks passed
@woorui woorui deleted the fix/client branch April 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants