Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connector can be customized in NewZipper() #801

Merged
merged 18 commits into from
Apr 29, 2024
Merged

Conversation

woorui
Copy link
Collaborator

@woorui woorui commented Apr 27, 2024

Make Connector become an interface, then the Connector can be customized in NewZipper()

@woorui woorui self-assigned this Apr 27, 2024
@woorui woorui requested a review from venjiang as a code owner April 27, 2024 16:08
Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
yomo ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:19am

Base automatically changed from feat/openai-stream to master April 29, 2024 03:18
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.90%. Comparing base (8e28a1b) to head (b5cce2a).

Files Patch % Lines
pkg/bridge/ai/ai.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   64.65%   64.90%   +0.24%     
==========================================
  Files          46       46              
  Lines        2640     2650      +10     
==========================================
+ Hits         1707     1720      +13     
+ Misses        818      817       -1     
+ Partials      115      113       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woorui woorui merged commit cd899d9 into master Apr 29, 2024
7 checks passed
@woorui woorui deleted the feat/zipper-option branch April 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants