meshwalk.js updated three.js #3

nutiler · 2017-09-27T03:20:27Z

Hello!

This is such a great repository for game, unit collision, controls, and more! I started to work on a project using meshwalk.js and saw there were a few depreciated methods while updating from three.js r73+. I went ahead and updated it to the latest version of three.js which is r88 dev but I do not believe anything else will depreciate in the near future.

Some things such as Three.WireFrameHelper I commented out so all of the examples don't have any warnings or errors as I'll get to updating those using Three.WireFrameGeometry.

I updated the README for all of the changes.

Please review this pull and let me know if you have any questions!

Thanks,

Josh Wilson
josh@stormheart.net

yomotsu · 2017-09-28T17:38:48Z

@nutiler Thanks for your contribution!

I wonder if you could load three.js from CDN. Could you change for all examples and delete three.js from this repo? Because it will cause large diff everytime.🙇
https://cdnjs.com/libraries/three.js/

Can we use es6-promise-auto instead of Bluebird.js? What we need is just loading following script instead of bluebard.js. Then, bluebird section in readme.md can be removed. (promise is already standard feature!)
https://cdnjs.cloudflare.com/ajax/libs/es6-promise/4.1.1/es6-promise.auto.min.js

I think we should have own EventDispacher in MeshWalk under MW namespace. I will prepare it later. In meantime, can we use THREE.EventDispatcher.prototype in three.js instead of external libraly?

yomotsu · 2017-09-28T17:57:05Z

README.md


+`THREE.r88 dev Compatible! :)`
+


I don't care older version compatibility for three.js. Could we remove this section?

Sure yeah, I was just writing that in case anyone has something in between 73-88 but those are obsolete with someone working on the latest version of threes and should update.

yomotsu · 2017-09-28T17:58:42Z

example/1_getstarted.html

@@ -20,6 +20,8 @@
 </div>

 <script src="../lib/three.min.js"></script>
+<script src="../lib/three.eventdispatcher.js"></script>
+


could we just use THREE.EventDispatcher.prototype instead loading external lib?

https://github.com/mrdoob/three.js/blob/dev/build/three.module.js
https://github.com/mrdoob/eventdispatcher.js/blob/master/src/EventDispatcher.js

three.module.js has THREE.EventDispatcher with it, it was taken out of three.core.js when it was depreciated in 74 according to the documentation. It was then moved to its own repository/modules which is the only one I added, the CDN has the module available but I included it from the original repository.

yomotsu · 2017-09-28T18:04:27Z

example/4_objects.html

@@ -70,7 +72,7 @@
 );
 ground.rotation.x = THREE.Math.degToRad( -90 );
 scene.add( ground );
-scene.add( new THREE.WireframeHelper( ground ) );
+// scene.add( new THREE.WireframeHelper( ground ) );


Could you uncomment for now or

var helper = new LineSegments( new WireframeGeometry( ground.geometry ), new LineBasicMaterial( { color: 0xffffff } ) ); scene.add( helper );

Yeah I just haven't had time to go through and make the wireframes for the original objects!

yomotsu · 2017-09-28T18:05:29Z

src/TPS/CharacterController.js

@@ -6,7 +6,7 @@

  ns.CharacterController = function ( object3d, radius ) {

-    THREE.EventDispatcher.prototype.apply( this );
+    Object.assign( ns.CharacterController.prototype, EventDispatcher.prototype );


Can we just assign THREE. EventDispatcher .Prototype?

THREE.EventDispatcher.prototype was completely removed, in its place THREE.EventDispatcher.apply works in previous versions, but as of now, it states: EventDispatcher.apply has been removed. Inherit or Object.assign the prototype to mix-in instead.

nutiler · 2017-09-29T00:03:49Z

@yomotsu

We can definitely switch to CDN's it will make it much smaller and cleaner as well, I'll be sure to do this next time I'm free. That's a great idea for promise-auto if we can make this more dependant on itself the better!

yomotsu · 2017-09-30T10:37:22Z

example/1_getstarted.html

@@ -13,10 +13,14 @@
  </div>

  <script src="https://cdnjs.cloudflare.com/ajax/libs/three.js/87/three.min.js"></script>
+  <!--<script src="https://cdnjs.cloudflare.com/ajax/libs/three.js/87/three.module.js"></script>-->


three.module.js is for bundler and unnecessary for "static JS". Could you remove this line please?

yomotsu · 2017-09-30T10:47:53Z

example/1_getstarted.html

-</style>
+  <meta charset="utf-8">
+  <title>1: Getting Started</title>
+  <link rel="stylesheet" href="./css/examples.css">


I was wondering if you could focus on main subject and purpose which support latest three.js, in this PR.

Otherwise, I cannot approve to merge until all change will be appropriated. I don't want to separate CSS from HTML source, as an example source, as well as some indent and spacing rules.🙇

You can separate this kind of extra change to another PR later.

I'm really sorry to have asked you so much. But I just want you to join as the first contributor🙇

But if you feel like it's a burden on you, feel free to leave it to me 👍

Heya I've been busy I was wondering if you've had a chance to look at the last commit?

sorry for very late...
seems your commits still contains unnecessary changes 😢
Could you check the diff please?

yomotsu · 2017-10-22T08:53:01Z

example/8_meshRemove.html

+    top: 0;
+    left: 0;
+  }
+  </style>


could you revert indents?

yomotsu · 2017-10-22T08:55:34Z

example/7_allTogether.html


+      })();


some spacings have been also changed
I prefer to keep kind of mrdoob's code style

Thundros · 2018-04-22T18:44:58Z

@yomotsu Please update the examples to use r92. ESPECIALLY the mesh_walk one & mobuko walkthrough one! Thank you!

yomotsu · 2018-04-24T03:58:10Z

@Thundros sorry, I forgot this. I will update sometime soon!

Thundros · 2018-04-24T08:40:49Z

@yomotsu how long? that's ok :)

Thundros · 2018-04-25T16:26:00Z

?

yomotsu · 2018-04-26T03:32:47Z

maybe this weekend

Thundros · 2018-04-26T16:22:59Z

Really?! That would be lovely! THANK you, @yomotsu !

Thundros · 2018-04-28T05:13:55Z

Hi @yomotsu ! Excellent as always on the update! Just thought I might mention that if you scale the terrain to say 20, 20, 20, it will make Miku fall through the terrain if the Terrain gets steep. How would I fix this? Thank you!

Thundros · 2018-04-28T22:13:09Z

Thanks alot, @yomotsu !

nutiler added 2 commits September 27, 2017 03:04

Updated libraries, three.js & bluebird.

e71dd0f

three.js r88, meshwalk.js updated depreciated methods from three.js r73

918b7c0

yomotsu reviewed Sep 28, 2017

View reviewed changes

nutiler added 2 commits September 29, 2017 02:32

Added CDN's, Remove libraries, updated wireframes.

39d445a

Added EventDispatcher, Cleaned up examples.

2a49077

yomotsu reviewed Sep 30, 2017

View reviewed changes

Removed module, unlinked css, and reverted spacing rules.

50e654b

yomotsu reviewed Oct 22, 2017

View reviewed changes

example/8_meshRemove.html

top: 0;

left: 0;

}

</style>

Copy link

Owner

yomotsu Oct 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you revert indents?

yomotsu reviewed Oct 22, 2017

View reviewed changes

example/7_allTogether.html

})();

Copy link

Owner

yomotsu Oct 22, 2017 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some spacings have been also changed
I prefer to keep kind of mrdoob's code style

yomotsu closed this Apr 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meshwalk.js updated three.js #3

meshwalk.js updated three.js #3

nutiler commented Sep 27, 2017

yomotsu commented Sep 28, 2017 •

edited

Loading

yomotsu Sep 28, 2017

nutiler Sep 28, 2017

yomotsu Sep 28, 2017

nutiler Sep 28, 2017

yomotsu Sep 28, 2017

nutiler Sep 28, 2017

yomotsu Sep 28, 2017

nutiler Sep 28, 2017

nutiler commented Sep 29, 2017

yomotsu Sep 30, 2017 •

edited

Loading

yomotsu Sep 30, 2017 •

edited

Loading

nutiler Oct 21, 2017

yomotsu Oct 22, 2017

yomotsu Oct 22, 2017

yomotsu Oct 22, 2017 •

edited

Loading

Thundros commented Apr 22, 2018 •

edited

Loading

yomotsu commented Apr 24, 2018

Thundros commented Apr 24, 2018

Thundros commented Apr 25, 2018

yomotsu commented Apr 26, 2018

Thundros commented Apr 26, 2018

Thundros commented Apr 28, 2018

Thundros commented Apr 28, 2018

meshwalk.js updated three.js #3

meshwalk.js updated three.js #3

Conversation

nutiler commented Sep 27, 2017

yomotsu commented Sep 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nutiler commented Sep 29, 2017

yomotsu Sep 30, 2017 • edited Loading

Choose a reason for hiding this comment

yomotsu Sep 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yomotsu Oct 22, 2017 • edited Loading

Choose a reason for hiding this comment

Thundros commented Apr 22, 2018 • edited Loading

yomotsu commented Apr 24, 2018

Thundros commented Apr 24, 2018

Thundros commented Apr 25, 2018

yomotsu commented Apr 26, 2018

Thundros commented Apr 26, 2018

Thundros commented Apr 28, 2018

Thundros commented Apr 28, 2018

yomotsu commented Sep 28, 2017 •

edited

Loading

yomotsu Sep 30, 2017 •

edited

Loading

yomotsu Sep 30, 2017 •

edited

Loading

yomotsu Oct 22, 2017 •

edited

Loading

Thundros commented Apr 22, 2018 •

edited

Loading