fix: when using -n option dont get all namespaces (#215)

Co-authored-by: Yonah Dissen <yonahdissen@Yonahs-MacBook-Pro.local>
yonahd · Feb 29, 2024 · 379f27a · 379f27a
1 parent d514994
commit 379f27a
Showing 1 changed file with 15 additions and 9 deletions.
diff --git a/pkg/filters/options.go b/pkg/filters/options.go
@@ -101,23 +101,29 @@ func (o *Options) Namespaces(clientset kubernetes.Interface) []string {
 		}
 		includeNamespaces := o.IncludeNamespaces
 		excludeNamespaces := o.ExcludeNamespaces
-		namespaceList, err := clientset.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
-		if err != nil {
-			fmt.Fprintf(os.Stderr, "Failed to retrieve namespaces: %v\n", err)
-			os.Exit(1)
-		}
+
 		if len(o.IncludeNamespaces) > 0 {
-			for _, ns := range namespaceList.Items {
-				namespacesMap[ns.Name] = false
-			}
+
 			for _, ns := range includeNamespaces {
-				if _, exists := namespacesMap[ns]; exists {
+
+				_, err := clientset.CoreV1().Namespaces().Get(context.TODO(), ns, metav1.GetOptions{})
+				if err == nil {
 					namespacesMap[ns] = true
 				} else {
 					fmt.Fprintf(os.Stderr, "namespace [%s] not found\n", ns)
 				}
 			}
 		} else {
+			namespaceList, err := clientset.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
+			if err != nil {
+				fmt.Fprintf(os.Stderr, "Failed to retrieve namespaces: %v\n", err)
+				os.Exit(1)
+			}
+
+			for _, ns := range namespaceList.Items {
+				namespacesMap[ns.Name] = false
+			}
+
 			for _, ns := range namespaceList.Items {
 				namespacesMap[ns.Name] = true
 			}