Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG(multi): Grouping by resource doesn't work in multi resource mode #289

Closed
doronkg opened this issue May 24, 2024 · 3 comments · Fixed by #320
Closed

BUG(multi): Grouping by resource doesn't work in multi resource mode #289

doronkg opened this issue May 24, 2024 · 3 comments · Fixed by #320
Assignees
Labels
bug Something isn't working

Comments

@doronkg
Copy link
Contributor

doronkg commented May 24, 2024

Describe the bug
Kor version v0.4.0 introduced a new feature for grouping output by resource: kor all --group-by=resource.
When grouping by resource in multi resource mode (e.g. resource_a,resource_b), the output is grouped by namespace (default).

To Reproduce
Run kor resource_a,resource_b --group-by=resource.

Expected behavior
The resources will be grouped by resource and not by namespace.

Screenshots

image

OS version, architecture and kor version
Kind v0.22.0 Windows/amd64, OpenShift v4.14.22 Linux/amd64
Kor version: 0.4.1

Additional context
#256

@yonahd yonahd added the bug Something isn't working label May 25, 2024
@yonahd
Copy link
Owner

yonahd commented May 27, 2024

Looks like the support for this was not built in for non table format. We need to add the support

@doronkg
Copy link
Contributor Author

doronkg commented May 27, 2024

Looks like the support for this was not built in for non table format. We need to add the support

It is not supported neither in table format.

@doronkg
Copy link
Contributor Author

doronkg commented Jun 23, 2024

/assign
WIP in #320

@doronkg doronkg changed the title Grouping by resource doesn't work in multi resource mode BUG(multi): Grouping by resource doesn't work in multi resource mode Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants