Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add version flag to ldflags and print version in banner #158

Merged
merged 1 commit into from Nov 22, 2023

Conversation

sidkhuntia
Copy link
Contributor

image

to generate binaries i ran the following command

goreleaser --snapshot --skip-publish --clean

I have tested the binaries for the following:

  1. darwin - arm64
  2. linux - amd64
  3. windows

Signed-off-by: Siddhartha Khuntia <siddharthakhuntia@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78cd227) 48.08% compared to head (80090ca) 45.86%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   48.08%   45.86%   -2.22%     
==========================================
  Files          20       20              
  Lines        1805     1888      +83     
==========================================
- Hits          868      866       -2     
- Misses        792      876      +84     
- Partials      145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@yonahd yonahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@yonahd yonahd merged commit b7b9b22 into yonahd:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants