Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ingress flag as used #169

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix ingress flag as used #169

merged 1 commit into from
Nov 29, 2023

Conversation

yonahd
Copy link
Owner

@yonahd yonahd commented Nov 29, 2023

Closing #166

@yonahd yonahd linked an issue Nov 29, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7f0367f) 45.52% compared to head (4d6fe2f) 45.55%.

Files Patch % Lines
pkg/kor/delete.go 0.00% 3 Missing ⚠️
pkg/kor/ingresses.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   45.52%   45.55%   +0.02%     
==========================================
  Files          21       21              
  Lines        1990     1991       +1     
==========================================
+ Hits          906      907       +1     
  Misses        930      930              
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonahd yonahd merged commit a459be1 into main Nov 29, 2023
1 check passed
@yonahd yonahd deleted the fix_used_label branch November 29, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kor/used label not implemented right for some resources
2 participants