-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consider ingress and egress rules for networkpolicies #310
Open
tthvo
wants to merge
10
commits into
yonahd:main
Choose a base branch
from
tthvo:netpol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 42.01% 42.39% +0.38%
==========================================
Files 61 61
Lines 3175 3236 +61
==========================================
+ Hits 1334 1372 +38
- Misses 1633 1644 +11
- Partials 208 220 +12 ☔ View full report in Codecov by Sentry. |
tthvo
force-pushed
the
netpol
branch
2 times, most recently
from
June 25, 2024 20:12
ca7c6b8
to
a55a8d8
Compare
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR added consideration for discovering second-level unused NetworkPolicies with matching
.spec.podSelector
, but unmatched pods in Ingress/Egress rules.See #296 (comment)
PR Checklist
GitHub Issue
Solves #312
Notes for your reviewers
Rules with
ipBlock
is considered "used" here.