-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(delete): Refactor input handling & output display on resource deletion #323
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 41.34% 41.77% +0.42%
==========================================
Files 61 61
Lines 3212 3179 -33
==========================================
Hits 1328 1328
+ Misses 1671 1637 -34
- Partials 213 214 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Small suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
What this PR does / why we need it?
This PR aims to resolve 2 outputing issues resulting in the
--delete
flag.-DELETED
suffix on deleted resources in outputPR Checklist
GitHub Issue
Closes #321
Closes #322
Notes for your reviewers
#321 is resolved by consuming the newline character ("\n") and removing it from the input buffer.
#322 is resolved by moving the deletion logic before the grouping logic, so the updated
diff
variable will be used.