feat: allow background images #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonasadiel
reviewed
Jun 21, 2024
| "permissions": [ | ||
| "storage" | ||
| ] | ||
| } |
There was a problem hiding this comment.
what's this file? it should already exist in the public dir?
| @@ -1,3 +1,4 @@ | |||
| /// <reference types="chrome"/> | |||
| <Particles /> | ||
| <img src={settings.themeBackgroundImagePath} /> | ||
| <img src={settings.themeBackgroundImageBase64 ? `data:image/jpeg;base64,` + settings.themeBackgroundImageBase64 : ""} /> |
There was a problem hiding this comment.
can you set it so that the image rendered correctly:
- If no image is configured, then dont need this img at all
- Add settings to adjust the background: alignment (left bottom / right top / center / etc), size (cover / contains / fit / etc)
- Feel free to change into css background if its better, I just put random
here just for future reminder.
| b64Image = btoa(new Uint8Array(result).reduce((data, byte) => data + String.fromCharCode(byte), '')); | ||
| setSettingValue('themeBackgroundImageBase64', b64Image); | ||
| }; | ||
| fileData.readAsArrayBuffer(fileName); |
There was a problem hiding this comment.
might be better to create separate function so that this can be just `loadImageAsBase64(filePath).then((base64Image) => setSettingValue('themeBackgroundImageBase64', base64Image))
| @@ -5,7 +5,7 @@ import db from '../dal/storage'; | |||
| export const defaultSettings: Settings = { | |||
| themeForegroundColor: 'white', | |||
| themeBackgroundColor: 'black', | |||
| themeBackgroundImagePath: undefined, | |||
| themeBackgroundImageBase64: undefined, | |||
There was a problem hiding this comment.
For discussion: do you think better to store the base64 somewhere else?
For example, use db.load('backgroundImage').
Then, when we open the devtools, the settings will still be easy to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.