New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SwiftStencilKit #111

Merged

yonaskolb merged 1 commit into master from stencilkit

Feb 20, 2019

Owner

yonaskolb commented Aug 30, 2018 •

edited

Loading

This replaces the custom fork of Stencil with StencilSwiftKit.
Resolves #48

Downsides are:

A huge performance impact. This seems to be due to the upgrade to Stencil 0.12.0. This should be fixed by Optimise Scanner performance stencilproject/Stencil#226
Line breaks are not handled correctly. This is using the automatic line break removal feature of StencilSwiftTemplate. This should be fixed properly by [Review] Jinja2-like whitespace trim behavior stencilproject/Stencil#92

EDIT:

performance regression has been resolved
line break issues are resolved except for the removal of line breaks in strings (like descriptions)


          use SwiftStencilKit

c79543e

yonaskolb force-pushed the stencilkit branch from be8bdea to c79543e Compare

February 20, 2019 09:48

yonaskolb changed the title ~~WIP: Use SwiftStencilKit~~ Use SwiftStencilKit

yonaskolb merged commit b7e2d92 into master

yonaskolb deleted the stencilkit branch

February 20, 2019 10:00

yonaskolb mentioned this pull request

Use StencilSwiftKit instead of Stencil #48

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment