Making Enum conform to Equatable and CaseIterable
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mackoj. Could you run the tests so that the fixtures get updated, and commit them. That's why the tests are failing. |
|
Ok, I will do it today. |
|
It actually breaks Swift 4.1 support because CaseIterable has been added in Swift 4.2 |
| @@ -1,14 +1,8 @@ | |||
| {% if description %} | |||
| /** {{ description }} */ | |||
| {% endif %} | |||
| public enum {{ enumName }}: {{ type }}, Codable { | |||
| public enum {{ enumName }}: {{ type }}, Codable, Equatable, CaseIterable { | |||
There was a problem hiding this comment.
I think you can conditionally use the template for swift 4.2 Vs 4.1
#if swift(>=4.2)
// swift 4.2 goes here
#else
// swift 4.1 goes here
#endifThere was a problem hiding this comment.
Good idea I will do it.
There was a problem hiding this comment.
I have done it but I still have to fix the fixture...
Remove old `cases` implementation and replacing it with `CaseIterable`
|
Perhaps a cleaner way would be to just define a custom #if swift(<4.2)
public protocol CaseIterable {
static let allCases: [Self] { get }
}
#endif |
|
In the interest of time I've just opened another PR here #133. I opted to simply drop Swift 4.1 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old
casesimplementation and replacing it withCaseIterable